starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 09:13:19 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #72] [CLOSED] chore: simplify container setup, drop down to node user #961

New Issue
Closed
opened 2025-10-07 00:25:24 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:25:24 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/72
Author: @kashalls
Created: 11/27/2024
Status: ❌ Closed

Base: main ← Head: nonroot

📝 Commits (3)

  • b3d25e6 chore: use included user to drop down to nonroot
  • d008ed9 chore: use included user to drop down to nonroot
  • eea7a25 chore: install additional required packages

📊 Changes

2 files changed (+15 additions, -48 deletions)

View changed files

📝 Dockerfile (+15 -17)
➖ scripts/docker/create-user.sh (+0 -31)

📄 Description

This PR uses the pre-existing node user. I tried to make the container smaller, but due to the size of node dependencies you can only really shave off 30MiB.

To further shave off and reduce the complexity of the docker container, you would need to split each application into their each container instead of offering a "all-in-one" container.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/72 **Author:** [@kashalls](https://github.com/kashalls) **Created:** 11/27/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `nonroot` --- ### 📝 Commits (3) - [`b3d25e6`](https://github.com/pocket-id/pocket-id/commit/b3d25e67dbe5cd52696cf5a4f913f4c15a4aa954) chore: use included user to drop down to nonroot - [`d008ed9`](https://github.com/pocket-id/pocket-id/commit/d008ed9978da72d4ad3ef48aa78c92316ce49488) chore: use included user to drop down to nonroot - [`eea7a25`](https://github.com/pocket-id/pocket-id/commit/eea7a25e2ff8c8c2b0669cb0a71a7f2c841aca89) chore: install additional required packages ### 📊 Changes **2 files changed** (+15 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+15 -17) ➖ `scripts/docker/create-user.sh` (+0 -31) </details> ### 📄 Description This PR uses the pre-existing [node user](https://github.com/nodejs/docker-node/blob/main/docs/BestPractices.md#non-root-user). I tried to make the container smaller, but due to the size of node dependencies you can only really shave off 30MiB. To further shave off and reduce the complexity of the docker container, you would need to split each application into their each container instead of offering a "all-in-one" container. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:25:24 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#961
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?