starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 01:10:22 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #130] [MERGED] fix: always set secure on cookie #945

New Issue
Open
opened 2025-10-07 00:25:08 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:25:08 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/130
Author: @cdanis
Created: 1/18/2025
Status: ✅ Merged
Merged: 1/19/2025
Merged by: @stonith404

Base: main ← Head: secure-cookie

📝 Commits (1)

  • ea29afd always set secure on cookie

📊 Changes

2 files changed (+6 additions, -6 deletions)

View changed files

📝 backend/internal/controller/user_controller.go (+2 -2)
📝 backend/internal/controller/webauthn_controller.go (+4 -4)

📄 Description

HTTPS is required for WebAuthn, so there's no downside to enabling this. And it prevents accidentally leaking an access token to the network in cleartext on an initial HTTP connection.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/130 **Author:** [@cdanis](https://github.com/cdanis) **Created:** 1/18/2025 **Status:** ✅ Merged **Merged:** 1/19/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `secure-cookie` --- ### 📝 Commits (1) - [`ea29afd`](https://github.com/pocket-id/pocket-id/commit/ea29afd87e9f33ad3e76f76c6495f29beb34837e) always set secure on cookie ### 📊 Changes **2 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/controller/user_controller.go` (+2 -2) 📝 `backend/internal/controller/webauthn_controller.go` (+4 -4) </details> ### 📄 Description HTTPS is required for WebAuthn, so there's no downside to enabling this. And it prevents accidentally leaking an access token to the network in cleartext on an initial HTTP connection. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:25:08 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#945
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?