[PR #258] [CLOSED] fix: generate valid urls when app url contains a trailing slash (#257) #895

New Issue

OVERLORD · 2025-10-07T00:24:13+03:00

OVERLORD commented

2025-10-07 00:24:13 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/258
Author: @nikdoof
Created: 2/22/2025
Status: ❌ Closed

Base: main ← Head: issue_257

📝 Commits (1)

e40ed50 fix: generate valid urls when app url contains a trailing slash (#257)

📊 Changes

6 files changed (+26 additions, -13 deletions)

View changed files

📝 backend/internal/controller/oidc_controller.go (+4 -3)
📝 backend/internal/controller/well_known_controller.go (+6 -5)
📝 backend/internal/service/email_service.go (+2 -1)
📝 backend/internal/service/oidc_service.go (+1 -1)
📝 backend/internal/service/user_service.go (+4 -3)
📝 backend/internal/utils/string_util.go (+9 -0)

📄 Description

A potential solution to #257, I am by no means a Go developer, so feel free to rewrite/close as needed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/258 **Author:** [@nikdoof](https://github.com/nikdoof) **Created:** 2/22/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `issue_257` --- ### 📝 Commits (1) - [`e40ed50`](https://github.com/pocket-id/pocket-id/commit/e40ed50bed50b24c5793c1dbd51be45c44be630b) fix: generate valid urls when app url contains a trailing slash (#257) ### 📊 Changes **6 files changed** (+26 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/controller/oidc_controller.go` (+4 -3) 📝 `backend/internal/controller/well_known_controller.go` (+6 -5) 📝 `backend/internal/service/email_service.go` (+2 -1) 📝 `backend/internal/service/oidc_service.go` (+1 -1) 📝 `backend/internal/service/user_service.go` (+4 -3) 📝 `backend/internal/utils/string_util.go` (+9 -0) </details> ### 📄 Description A potential solution to #257, I am by no means a Go developer, so feel free to rewrite/close as needed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-07 00:24:14 +03:00

OVERLORD closed this issue

2025-10-07 00:24:15 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id#895