[PR #268] [MERGED] fix: add option to manually select SMTP TLS method #893

New Issue

OVERLORD · 2025-10-07T00:24:12+03:00

OVERLORD commented

2025-10-07 00:24:12 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/268
Author: @kmendell
Created: 2/25/2025
Status: ✅ Merged
Merged: 2/25/2025
Merged by: @stonith404

Base: main ← Head: smtp-ports

📝 Commits (4)

7f2d420 fix: smtp tls option selector
61cb13c replace migration with sql migration
0ec9ecc fix label displayed correctly
ab55451 fix postgres migration

📊 Changes

10 files changed (+55 additions, -17 deletions)

View changed files

📝 backend/internal/dto/app_config_dto.go (+1 -1)
📝 backend/internal/service/app_config_service.go (+3 -2)
📝 backend/internal/service/email_service.go (+7 -3)
➕ backend/resources/migrations/postgres/20250225182112_manual_smtp_tls_selection.down.sql (+1 -0)
➕ backend/resources/migrations/postgres/20250225182112_manual_smtp_tls_selection.up.sql (+7 -0)
➕ backend/resources/migrations/sqlite/20250225182112_manual_smtp_tls_selection.down.sql (+1 -0)
➕ backend/resources/migrations/sqlite/20250225182112_manual_smtp_tls_selection.up.sql (+7 -0)
📝 frontend/package-lock.json (+2 -2)
📝 frontend/src/lib/types/application-configuration.ts (+1 -1)
📝 frontend/src/routes/settings/admin/application-configuration/forms/app-config-email-form.svelte (+25 -8)

📄 Description

Fixes: https://github.com/pocket-id/pocket-id/issues/264

I tested and this works, but could maybe be cleaner, or some stuff could be changed a bit.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/268 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 2/25/2025 **Status:** ✅ Merged **Merged:** 2/25/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `smtp-ports` --- ### 📝 Commits (4) - [`7f2d420`](https://github.com/pocket-id/pocket-id/commit/7f2d420d2e446add7c21d8890ea103ddd46fc920) fix: smtp tls option selector - [`61cb13c`](https://github.com/pocket-id/pocket-id/commit/61cb13c53d91d23d011922d82f9f53eff3fa0bb3) replace migration with sql migration - [`0ec9ecc`](https://github.com/pocket-id/pocket-id/commit/0ec9eccf088b0411552121af118518b1f4035700) fix label displayed correctly - [`ab55451`](https://github.com/pocket-id/pocket-id/commit/ab55451307be53ac065d415b5121de70adb0212b) fix postgres migration ### 📊 Changes **10 files changed** (+55 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/dto/app_config_dto.go` (+1 -1) 📝 `backend/internal/service/app_config_service.go` (+3 -2) 📝 `backend/internal/service/email_service.go` (+7 -3) ➕ `backend/resources/migrations/postgres/20250225182112_manual_smtp_tls_selection.down.sql` (+1 -0) ➕ `backend/resources/migrations/postgres/20250225182112_manual_smtp_tls_selection.up.sql` (+7 -0) ➕ `backend/resources/migrations/sqlite/20250225182112_manual_smtp_tls_selection.down.sql` (+1 -0) ➕ `backend/resources/migrations/sqlite/20250225182112_manual_smtp_tls_selection.up.sql` (+7 -0) 📝 `frontend/package-lock.json` (+2 -2) 📝 `frontend/src/lib/types/application-configuration.ts` (+1 -1) 📝 `frontend/src/routes/settings/admin/application-configuration/forms/app-config-email-form.svelte` (+25 -8) </details> ### 📄 Description Fixes: https://github.com/pocket-id/pocket-id/issues/264 I tested and this works, but could maybe be cleaner, or some stuff could be changed a bit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-07 00:24:12 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id#893