starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 09:13:19 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #265] [CLOSED] feat: add support for TRUSTED_PROXIES environment variable #892

New Issue
Closed
opened 2025-10-07 00:24:12 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:24:12 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/265
Author: @savely-krasovsky
Created: 2/24/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (1)

  • 9b5110c feat: add support for TRUSTED_PROXIES environment variable

📊 Changes

2 files changed (+10 additions, -0 deletions)

View changed files

📝 backend/internal/bootstrap/router_bootstrap.go (+7 -0)
📝 backend/internal/common/env_config.go (+3 -0)

📄 Description

Enable configuration of trusted proxies via a new TRUSTED_PROXIES env variable. Unfortunately Gin default ClientIP() logic very obscure. Should fix #263, will test it soon and update.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/265 **Author:** [@savely-krasovsky](https://github.com/savely-krasovsky) **Created:** 2/24/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`9b5110c`](https://github.com/pocket-id/pocket-id/commit/9b5110cd9b87d96c8b62ab3d66bed2b63549d591) feat: add support for TRUSTED_PROXIES environment variable ### 📊 Changes **2 files changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/bootstrap/router_bootstrap.go` (+7 -0) 📝 `backend/internal/common/env_config.go` (+3 -0) </details> ### 📄 Description Enable configuration of trusted proxies via a new `TRUSTED_PROXIES` env variable. Unfortunately Gin default ClientIP() logic very obscure. Should fix #263, will test it soon and update. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:24:12 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#892
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?