starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 01:10:22 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #277] [MERGED] feat: enable sd_notify support #886

New Issue
Open
opened 2025-10-07 00:24:05 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:24:05 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/277
Author: @savely-krasovsky
Created: 3/1/2025
Status: ✅ Merged
Merged: 3/6/2025
Merged by: @stonith404

Base: main ← Head: main

📝 Commits (4)

  • 061e80c feat: enable sd_notify support
  • 467f00e feat: drop github.com/coreos/go-systemd/v22, reimplement simpler version of systemd sd_notify
  • 1c66fde fix: simplify SdNotify logic
  • dddb153 Merge branch 'main' into main

📊 Changes

2 files changed (+49 additions, -2 deletions)

View changed files

📝 backend/internal/bootstrap/router_bootstrap.go (+16 -2)
➕ backend/internal/utils/systemd/sdnotify.go (+33 -0)

📄 Description

Podman supports it natively, that allows to manage dependencies without using healthchecks. For example oauth2-proxy automatically fetches OIDC configuration after every launch, in case there Pocket-ID is not yet ready it will fail.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/277 **Author:** [@savely-krasovsky](https://github.com/savely-krasovsky) **Created:** 3/1/2025 **Status:** ✅ Merged **Merged:** 3/6/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`061e80c`](https://github.com/pocket-id/pocket-id/commit/061e80c62a3b9d5aa2ea57bfba26c505f7949b83) feat: enable sd_notify support - [`467f00e`](https://github.com/pocket-id/pocket-id/commit/467f00eb77162cca17f534e5f203c6f912a0e6e9) feat: drop github.com/coreos/go-systemd/v22, reimplement simpler version of systemd sd_notify - [`1c66fde`](https://github.com/pocket-id/pocket-id/commit/1c66fded42a6f21b8cd61f26995a7e1da078a31f) fix: simplify SdNotify logic - [`dddb153`](https://github.com/pocket-id/pocket-id/commit/dddb1533852305b3ac69aaf734c1d8ea5ab0d5c9) Merge branch 'main' into main ### 📊 Changes **2 files changed** (+49 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/bootstrap/router_bootstrap.go` (+16 -2) ➕ `backend/internal/utils/systemd/sdnotify.go` (+33 -0) </details> ### 📄 Description Podman supports it natively, that allows to manage dependencies without using healthchecks. For example oauth2-proxy automatically fetches OIDC configuration after every launch, in case there Pocket-ID is not yet ready it will fail. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:24:05 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#886
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?