starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 09:13:19 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #303] [CLOSED] fix: sorting not applying on page load #877

New Issue
Closed
opened 2025-10-07 00:23:54 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:23:54 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/303
Author: @kmendell
Created: 3/9/2025
Status: ❌ Closed

Base: main ← Head: fix/user-group-sorting

📝 Commits (2)

  • f970b8f fix: sorting not applying on page load
  • 7c8cda7 chore: remove old commented code

📊 Changes

6 files changed (+32 additions, -7 deletions)

View changed files

📝 frontend/src/lib/components/user-group-selection.svelte (+9 -1)
📝 frontend/src/lib/services/user-group-service.ts (+4 -2)
📝 frontend/src/routes/settings/admin/user-groups/[id]/+page.server.ts (+15 -1)
📝 frontend/src/routes/settings/admin/user-groups/user-selection.svelte (+2 -2)
📝 frontend/src/routes/settings/admin/users/[id]/+page.server.ts (+1 -0)
📝 frontend/src/routes/settings/admin/users/[id]/+page.svelte (+1 -1)

📄 Description

Missed Bug form the latest update sorting not working for the user groups on the user form.

See comments here: https://github.com/pocket-id/pocket-id/issues/298#issuecomment-2708723234

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/303 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 3/9/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/user-group-sorting` --- ### 📝 Commits (2) - [`f970b8f`](https://github.com/pocket-id/pocket-id/commit/f970b8fe2ab39e18282ab0a146c7f5ea6a77e7c8) fix: sorting not applying on page load - [`7c8cda7`](https://github.com/pocket-id/pocket-id/commit/7c8cda74cbe91091e92ebb1e83d537094c577d02) chore: remove old commented code ### 📊 Changes **6 files changed** (+32 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/lib/components/user-group-selection.svelte` (+9 -1) 📝 `frontend/src/lib/services/user-group-service.ts` (+4 -2) 📝 `frontend/src/routes/settings/admin/user-groups/[id]/+page.server.ts` (+15 -1) 📝 `frontend/src/routes/settings/admin/user-groups/user-selection.svelte` (+2 -2) 📝 `frontend/src/routes/settings/admin/users/[id]/+page.server.ts` (+1 -0) 📝 `frontend/src/routes/settings/admin/users/[id]/+page.svelte` (+1 -1) </details> ### 📄 Description Missed Bug form the latest update sorting not working for the user groups on the user form. See comments here: https://github.com/pocket-id/pocket-id/issues/298#issuecomment-2708723234 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:23:55 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#877
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?