starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2026-07-16 05:54:01 +03:00
Code Issues 61 Packages Projects Releases 21 Wiki Activity

[PR #583] [MERGED] feat: auto detect callback url #847

New Issue
Closed
opened 2026-02-04 20:58:23 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 20:58:23 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/583
Author: @kmendell
Created: 5/28/2025
Status: ✅ Merged
Merged: 5/29/2025
Merged by: @stonith404

Base: main ← Head: feat/detect-callback-url

📝 Commits (7)

📊 Changes

8 files changed (+67 additions, -36 deletions)

View changed files

📝 backend/internal/common/errors.go (+7 -0)
📝 backend/internal/dto/oidc_dto.go (+1 -1)
📝 backend/internal/service/oidc_service.go (+45 -13)
📝 frontend/messages/en-US.json (+1 -1)
📝 frontend/src/lib/types/oidc.type.ts (+1 -1)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-callback-url-input.svelte (+7 -11)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte (+2 -3)
📝 tests/specs/oidc-client-settings.spec.ts (+3 -6)

📄 Description

fixes: https://github.com/pocket-id/pocket-id/issues/538

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/583 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 5/28/2025 **Status:** ✅ Merged **Merged:** 5/29/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `feat/detect-callback-url` --- ### 📝 Commits (7) - [`b064e0d`](https://github.com/pocket-id/pocket-id/commit/b064e0d78d03d9f6a85317b4e85663ada2cf7d3c) feat: auto detect callback url - [`5a9b915`](https://github.com/pocket-id/pocket-id/commit/5a9b9150391eaadaa96466d78abf69be4ff3e741) update description text - [`a263a82`](https://github.com/pocket-id/pocket-id/commit/a263a82957dd095a091a4e9529152018196b2da2) update error text - [`14c5af5`](https://github.com/pocket-id/pocket-id/commit/14c5af580eb9585fdcdf50ab0923379eaeae9ba1) fix tests - [`d3b4527`](https://github.com/pocket-id/pocket-id/commit/d3b4527a350889704d2a15611fe9b84018bef709) disallow empty callback URL - [`52ac1d8`](https://github.com/pocket-id/pocket-id/commit/52ac1d86bbd0324786b8794f82fa5fd13756aa04) remove unnecessary `isEmpty` property - [`e533dc1`](https://github.com/pocket-id/pocket-id/commit/e533dc1f979c2f8a67c756e84e6d48dfb077c4e9) remove unnecessary comments ### 📊 Changes **8 files changed** (+67 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/common/errors.go` (+7 -0) 📝 `backend/internal/dto/oidc_dto.go` (+1 -1) 📝 `backend/internal/service/oidc_service.go` (+45 -13) 📝 `frontend/messages/en-US.json` (+1 -1) 📝 `frontend/src/lib/types/oidc.type.ts` (+1 -1) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-callback-url-input.svelte` (+7 -11) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte` (+2 -3) 📝 `tests/specs/oidc-client-settings.spec.ts` (+3 -6) </details> ### 📄 Description fixes: https://github.com/pocket-id/pocket-id/issues/538 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 20:58:23 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
bug
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#847
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?