starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2026-02-05 00:39:38 +03:00
Code Issues 61 Packages Projects Releases 10 Wiki Activity

🐛 Bug Report: OIDC Client Details wrong value for PKCE #83

New Issue
Closed
opened 2026-02-04 17:10:12 +03:00 by OVERLORD · 7 comments
OVERLORD commented 2026-02-04 17:10:12 +03:00
Owner
Copy Link

Originally created by @simon-eller on GitHub (Jan 9, 2025).

Reproduction steps

  1. Navigate to "OIDC Clients" and "Add OIDC Client"
  2. Enter credentials and uncheck "PKCE" and click on "Save"
  3. In the details click on "Show more details"
  4. Option PKCE is Disabled
  5. Now check "PKCE" save it again and the value of PKCE is still displayed as Disabled

Expected behavior

The value of PKCE should be displayed as Enabled if it is enabled.

Actual Behavior

No matter if PKCE is checked or unchecked it is always displayed as Disabled

pocket-id-screenshot

Originally created by @simon-eller on GitHub (Jan 9, 2025). ### Reproduction steps 1. Navigate to "OIDC Clients" and "Add OIDC Client" 2. Enter credentials and uncheck "PKCE" and click on "Save" 3. In the details click on "Show more details" 4. Option `PKCE` is `Disabled` 5. Now check "PKCE" save it again and the value of `PKCE` is still displayed as `Disabled` ### Expected behavior The value of `PKCE` should be displayed as `Enabled` if it is enabled. ### Actual Behavior No matter if `PKCE` is checked or unchecked it is always displayed as `Disabled` ![pocket-id-screenshot](https://github.com/user-attachments/assets/35b4c1a3-badb-4bf8-85b6-1d61dc6c4270)
OVERLORD added the bug label 2026-02-04 17:10:12 +03:00
OVERLORD commented 2026-02-04 17:10:29 +03:00
Author
Owner
Copy Link

@simon-eller commented on GitHub (Jan 9, 2025):

I think i found the issue in frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte at line 30:

PKCE: client.isPublic ? 'Enabled' : 'Disabled'

should be

PKCE: client.pkceEnabled ? 'Enabled' : 'Disabled'
@simon-eller commented on GitHub (Jan 9, 2025): I think i found the issue in frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte at line 30: ``` PKCE: client.isPublic ? 'Enabled' : 'Disabled' ``` should be ``` PKCE: client.pkceEnabled ? 'Enabled' : 'Disabled' ```
OVERLORD commented 2026-02-04 17:10:34 +03:00
Author
Owner
Copy Link

@parhammhd commented on GitHub (Jan 11, 2025):

I have the same issue as well, not sure if that is the case but I am getting errors trying to use Pocket ID for Pingvin Share possibly because of not being able to enable PKCE.

@parhammhd commented on GitHub (Jan 11, 2025): I have the same issue as well, not sure if that is the case but I am getting errors trying to use Pocket ID for Pingvin Share possibly because of not being able to enable PKCE.
OVERLORD commented 2026-02-04 17:10:41 +03:00
Author
Owner
Copy Link

@stonith404 commented on GitHub (Jan 11, 2025):

think i found the issue in frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte at line 30:

Yes thanks, that's the issue.

@stonith404 commented on GitHub (Jan 11, 2025): > think i found the issue in frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte at line 30: Yes thanks, that's the issue.
OVERLORD commented 2026-02-04 17:10:51 +03:00
Author
Owner
Copy Link

@stonith404 commented on GitHub (Jan 11, 2025):

@parhammhd It's just a display bug. Everything should still work as expected.

Pingvin Share doesn't support PKCE so you have to disable it. Which error do you get?

@stonith404 commented on GitHub (Jan 11, 2025): @parhammhd It's just a display bug. Everything should still work as expected. Pingvin Share doesn't support PKCE so you have to disable it. Which error do you get?
OVERLORD commented 2026-02-04 17:10:57 +03:00
Author
Owner
Copy Link

@parhammhd commented on GitHub (Jan 11, 2025):

@parhammhd It's just a display bug. Everything should still work as expected.

Pingvin Share doesn't support PKCE so you have to disable it. Which error do you get?

Thanks, it fixed my issue, just had to disable it 😁🙏🏻

@parhammhd commented on GitHub (Jan 11, 2025): > @parhammhd It's just a display bug. Everything should still work as expected. > > Pingvin Share doesn't support PKCE so you have to disable it. Which error do you get? Thanks, it fixed my issue, just had to disable it 😁🙏🏻
OVERLORD commented 2026-02-04 17:11:00 +03:00
Author
Owner
Copy Link

@stonith404 commented on GitHub (Jan 11, 2025):

This should be fixed in v0.24.0

@stonith404 commented on GitHub (Jan 11, 2025): This should be fixed in `v0.24.0`
OVERLORD commented 2026-02-04 17:11:07 +03:00
Author
Owner
Copy Link

@simon-eller commented on GitHub (Jan 11, 2025):

Thanks a lot! Btw very cool project. 👍🏼

@simon-eller commented on GitHub (Jan 11, 2025): Thanks a lot! Btw very cool project. 👍🏼
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
bug
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#83
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?