starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 09:13:19 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #406] [MERGED] fix: create reusable default profile pictures #817

New Issue
Closed
opened 2025-10-07 00:22:54 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:22:54 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/406
Author: @kmendell
Created: 3/31/2025
Status: ✅ Merged
Merged: 4/3/2025
Merged by: @kmendell

Base: main ← Head: fix/pfp-cache

📝 Commits (10+)

  • 6667d4c fix: use initials for default profile picture
  • ba6e04a fix: incorrect profile picture callback on account page
  • dcba03b add migration logic for new profile pictures
  • 578e021 move openapi3 comment to main.go
  • e233ec4 check error return value
  • cb3b124 remove my comments
  • 68d834f Merge branch 'main' into fix/pfp-cache
  • 9d815d1 move initials function to user struct
  • 3e043f1 remove migration
  • 430df07 add job to clear unused profile pictures

📊 Changes

9 files changed (+166 additions, -46 deletions)

View changed files

📝 backend/cmd/main.go (+4 -0)
📝 backend/internal/bootstrap/router_bootstrap.go (+1 -3)
📝 backend/internal/job/db_cleanup_job.go (+7 -27)
➕ backend/internal/job/file_cleanup_job.go (+78 -0)
➕ backend/internal/job/job.go (+27 -0)
📝 backend/internal/model/user.go (+13 -0)
📝 backend/internal/service/user_service.go (+33 -2)
📝 backend/internal/utils/image/profile_picture.go (+1 -12)
📝 frontend/src/routes/settings/account/account-form.svelte (+2 -2)

📄 Description

Fixes: https://github.com/pocket-id/pocket-id/issues/390

This PR also include a fix for the Uploading and Resetting of profile pictures on the My Account page: ba6e04aa4a

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/406 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 3/31/2025 **Status:** ✅ Merged **Merged:** 4/3/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `fix/pfp-cache` --- ### 📝 Commits (10+) - [`6667d4c`](https://github.com/pocket-id/pocket-id/commit/6667d4c23ead43753bef3c2a2554ffa6633cea4d) fix: use initials for default profile picture - [`ba6e04a`](https://github.com/pocket-id/pocket-id/commit/ba6e04aa4a4c4d5602347b24e872e0a715451a0c) fix: incorrect profile picture callback on account page - [`dcba03b`](https://github.com/pocket-id/pocket-id/commit/dcba03b4362d41341b9970b2a4b9fe270413219c) add migration logic for new profile pictures - [`578e021`](https://github.com/pocket-id/pocket-id/commit/578e02188c2dec42466479d43c52682304b6fdfb) move openapi3 comment to main.go - [`e233ec4`](https://github.com/pocket-id/pocket-id/commit/e233ec40a8078c9ea37c0dece92a53d8dd674fc4) check error return value - [`cb3b124`](https://github.com/pocket-id/pocket-id/commit/cb3b1244db19d03080e093ea087de91281f1df99) remove my comments - [`68d834f`](https://github.com/pocket-id/pocket-id/commit/68d834f059ace2565cd523500464bf7aa5b4b229) Merge branch 'main' into fix/pfp-cache - [`9d815d1`](https://github.com/pocket-id/pocket-id/commit/9d815d115c598ec6d89913ec43ebd4366cee666c) move initials function to user struct - [`3e043f1`](https://github.com/pocket-id/pocket-id/commit/3e043f1f022f0be0101828aee56ca36abe3d5576) remove migration - [`430df07`](https://github.com/pocket-id/pocket-id/commit/430df07fdd5cce54bf0bc6dbdce09f33c6af5da3) add job to clear unused profile pictures ### 📊 Changes **9 files changed** (+166 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `backend/cmd/main.go` (+4 -0) 📝 `backend/internal/bootstrap/router_bootstrap.go` (+1 -3) 📝 `backend/internal/job/db_cleanup_job.go` (+7 -27) ➕ `backend/internal/job/file_cleanup_job.go` (+78 -0) ➕ `backend/internal/job/job.go` (+27 -0) 📝 `backend/internal/model/user.go` (+13 -0) 📝 `backend/internal/service/user_service.go` (+33 -2) 📝 `backend/internal/utils/image/profile_picture.go` (+1 -12) 📝 `frontend/src/routes/settings/account/account-form.svelte` (+2 -2) </details> ### 📄 Description Fixes: https://github.com/pocket-id/pocket-id/issues/390 This PR also include a fix for the Uploading and Resetting of profile pictures on the My Account page: ba6e04aa4a4c4d5602347b24e872e0a715451a0c --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:22:54 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#817
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?