starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-11 01:10:40 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #436] [MERGED] feat: add qrcode representation of one time link (#424) #799

New Issue
Open
opened 2025-10-07 00:22:35 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:22:35 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/436
Author: @paulgreg
Created: 4/13/2025
Status: ✅ Merged
Merged: 4/14/2025
Merged by: @stonith404

Base: main ← Head: qrcode-424

📝 Commits (9)

  • 03267a0 feat: add qrcode representation of one time link (#424)
  • cbb6c81 update styling of qr code
  • 7bc8da7 Merge branch 'main' into qrcode-424
  • 3048601 update layout of one time access modal to align better with login code modal
  • 1b8e26f use testid instead of input box
  • 0efb415 refactor: use bind:this instead of getElementById
  • bbc598b simplify qr code component add add light mode support
  • 15b5e0a fix tests
  • 237d020 Merge branch 'main' into qrcode-424

📊 Changes

9 files changed (+5643 additions, -5285 deletions)

View changed files

📝 frontend/package-lock.json (+5467 -5198)
📝 frontend/package.json (+60 -58)
📝 frontend/src/lib/components/one-time-link-modal.svelte (+37 -7)
➕ frontend/src/lib/components/qrcode/qrcode.svelte (+42 -0)
📝 frontend/src/routes/settings/account/login-code-modal.svelte (+19 -7)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-client-list.svelte (+1 -6)
📝 frontend/tests/account-settings.spec.ts (+1 -1)
📝 frontend/tests/api-key.spec.ts (+1 -1)
📝 frontend/tests/user-settings.spec.ts (+15 -7)

📄 Description

My proposal to display a QRCode for one time links as discussed in #424

It’s my first PR on a Svelte project so feel free to tell me what can be enhanced. Sorry If that’s look ugly to a Svelte expert 😅

Fixes: https://github.com/pocket-id/pocket-id/issues/424

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/436 **Author:** [@paulgreg](https://github.com/paulgreg) **Created:** 4/13/2025 **Status:** ✅ Merged **Merged:** 4/14/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `qrcode-424` --- ### 📝 Commits (9) - [`03267a0`](https://github.com/pocket-id/pocket-id/commit/03267a0b1c5e46d27d75d0ba813aab5c49bb0bf3) feat: add qrcode representation of one time link (#424) - [`cbb6c81`](https://github.com/pocket-id/pocket-id/commit/cbb6c8178fa30f1c48f4aea88fe14e6146f37dfc) update styling of qr code - [`7bc8da7`](https://github.com/pocket-id/pocket-id/commit/7bc8da7d7198c0006e22b0490392bdc942d0da24) Merge branch 'main' into qrcode-424 - [`3048601`](https://github.com/pocket-id/pocket-id/commit/30486017a726557e79edf8f05f4be2eb128206c5) update layout of one time access modal to align better with login code modal - [`1b8e26f`](https://github.com/pocket-id/pocket-id/commit/1b8e26f5cfbc9ded3f69a45de2ca8d90f3dcbec4) use testid instead of input box - [`0efb415`](https://github.com/pocket-id/pocket-id/commit/0efb4153a78406779ba4c1a59805813b5ed54057) refactor: use bind:this instead of getElementById - [`bbc598b`](https://github.com/pocket-id/pocket-id/commit/bbc598b72f256b2649d960539f5f5f6c0cb0b5c3) simplify qr code component add add light mode support - [`15b5e0a`](https://github.com/pocket-id/pocket-id/commit/15b5e0a56a1824bda5d0020c0a91f4ab94490f05) fix tests - [`237d020`](https://github.com/pocket-id/pocket-id/commit/237d02071e20aa3778f9d0fb7679fb39ed3dc941) Merge branch 'main' into qrcode-424 ### 📊 Changes **9 files changed** (+5643 additions, -5285 deletions) <details> <summary>View changed files</summary> 📝 `frontend/package-lock.json` (+5467 -5198) 📝 `frontend/package.json` (+60 -58) 📝 `frontend/src/lib/components/one-time-link-modal.svelte` (+37 -7) ➕ `frontend/src/lib/components/qrcode/qrcode.svelte` (+42 -0) 📝 `frontend/src/routes/settings/account/login-code-modal.svelte` (+19 -7) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-client-list.svelte` (+1 -6) 📝 `frontend/tests/account-settings.spec.ts` (+1 -1) 📝 `frontend/tests/api-key.spec.ts` (+1 -1) 📝 `frontend/tests/user-settings.spec.ts` (+15 -7) </details> ### 📄 Description My proposal to display a QRCode for one time links as discussed in #424 It’s my first PR on a Svelte project so feel free to tell me what can be enhanced. Sorry If that’s look ugly to a Svelte expert :sweat_smile: Fixes: https://github.com/pocket-id/pocket-id/issues/424 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:22:35 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#799
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?