starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 09:13:19 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #442] [MERGED] feat: disable animations setting toggle #792

New Issue
Closed
opened 2025-10-07 00:22:28 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:22:28 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/442
Author: @kmendell
Created: 4/14/2025
Status: ✅ Merged
Merged: 4/15/2025
Merged by: @kmendell

Base: main ← Head: feat/disable-animations

📝 Commits (10+)

  • e5c7c7e feat: disable animations setting toggle
  • 4208137 add translations
  • 968d41e add translations
  • b2a4bb0 make sure disableAnimations is defined in appConfig service
  • ad865ee make sure the backend matches the frontend default value
  • 3c81d84 make sure the backend matches the frontend default value
  • fdd707f fix fade wrapper not disabling animations on first load
  • c0a6a9e simplify fade wrapper logic
  • dc12df2 disable sidebar animation if animations disabled
  • 9d91e5d remove unused css class

📊 Changes

11 files changed (+34 additions, -12 deletions)

View changed files

📝 backend/internal/dto/app_config_dto.go (+1 -0)
📝 backend/internal/model/app_config.go (+1 -0)
📝 backend/internal/service/app_config_service.go (+1 -0)
📝 frontend/messages/en-US.json (+3 -1)
📝 frontend/src/lib/components/fade-wrapper.svelte (+8 -3)
📝 frontend/src/lib/types/application-configuration.ts (+1 -0)
📝 frontend/src/routes/login/+page.svelte (+1 -1)
📝 frontend/src/routes/login/alternative/+page.svelte (+1 -1)
📝 frontend/src/routes/login/setup/+page.svelte (+1 -1)
📝 frontend/src/routes/settings/+layout.svelte (+6 -3)
📝 frontend/src/routes/settings/admin/application-configuration/forms/app-config-general-form.svelte (+10 -2)

📄 Description

Fixes: https://github.com/pocket-id/pocket-id/issues/441

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/442 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 4/14/2025 **Status:** ✅ Merged **Merged:** 4/15/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `feat/disable-animations` --- ### 📝 Commits (10+) - [`e5c7c7e`](https://github.com/pocket-id/pocket-id/commit/e5c7c7e297222ca39373b258ced6274d8b7bb150) feat: disable animations setting toggle - [`4208137`](https://github.com/pocket-id/pocket-id/commit/4208137e5d8262914521e1589e1c43b4363416e1) add translations - [`968d41e`](https://github.com/pocket-id/pocket-id/commit/968d41ec1b286e535eb1ec7b43860260493cc530) add translations - [`b2a4bb0`](https://github.com/pocket-id/pocket-id/commit/b2a4bb0705c6f7bac8b6f1ad3fb7ff944b059efd) make sure disableAnimations is defined in appConfig service - [`ad865ee`](https://github.com/pocket-id/pocket-id/commit/ad865ee9bd5c80c831e37a6e8f1459612094e804) make sure the backend matches the frontend default value - [`3c81d84`](https://github.com/pocket-id/pocket-id/commit/3c81d841dd29188fa31322d8cce8906422bb28c6) make sure the backend matches the frontend default value - [`fdd707f`](https://github.com/pocket-id/pocket-id/commit/fdd707f37224ae5fa157edeb067d33e546672e23) fix fade wrapper not disabling animations on first load - [`c0a6a9e`](https://github.com/pocket-id/pocket-id/commit/c0a6a9e551d955fa2193f357625fb52a23ff050f) simplify fade wrapper logic - [`dc12df2`](https://github.com/pocket-id/pocket-id/commit/dc12df254112f30a09813b957aeefca7e1489392) disable sidebar animation if animations disabled - [`9d91e5d`](https://github.com/pocket-id/pocket-id/commit/9d91e5dcfa85e8634795691e5f0926112cfc305d) remove unused css class ### 📊 Changes **11 files changed** (+34 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/dto/app_config_dto.go` (+1 -0) 📝 `backend/internal/model/app_config.go` (+1 -0) 📝 `backend/internal/service/app_config_service.go` (+1 -0) 📝 `frontend/messages/en-US.json` (+3 -1) 📝 `frontend/src/lib/components/fade-wrapper.svelte` (+8 -3) 📝 `frontend/src/lib/types/application-configuration.ts` (+1 -0) 📝 `frontend/src/routes/login/+page.svelte` (+1 -1) 📝 `frontend/src/routes/login/alternative/+page.svelte` (+1 -1) 📝 `frontend/src/routes/login/setup/+page.svelte` (+1 -1) 📝 `frontend/src/routes/settings/+layout.svelte` (+6 -3) 📝 `frontend/src/routes/settings/admin/application-configuration/forms/app-config-general-form.svelte` (+10 -2) </details> ### 📄 Description Fixes: https://github.com/pocket-id/pocket-id/issues/441 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:22:28 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#792
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?