mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-09 17:23:22 +03:00
🚀 Feature: include extra information in access token #79
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @peterforeman on GitHub.
Feature description
Allow extra claims to access token.
Pitch
I'm trying to get RabbitMQ working with Pocket-ID, but unfortunately their implementation only makes use of the access token. Other SSO providers like Zitadel or Authentik have the option to include extra data in the access token. In Pocket-ID I cannot find such feature.
From the RabbitMQ docs:
There are probably more applications that want extra claims in the access token since the big SSO providers have this option as well.
@peterforeman commented on GitHub:
Agreed. Then an API like your proposal would be better.
@peterforeman commented on GitHub:
#781 would fix this if we would also allow access token to have custom claims, closing this one.
@ItalyPaleAle commented on GitHub:
The problem with this would be requiring executing custom code (i.e. untrusted) within Pocket ID. It can be done, but it does come with significant challenges in terms of maintenability and security.
@ItalyPaleAle commented on GitHub:
Would #781 address this too?
@peterforeman commented on GitHub:
I think it would, although I'm not sure if using a HTTP(s) backend would we a industry-standard approach. But I'm not really into OIDC so am unable to tell.
I did some own tweaking with custom claims and that worked. The approach was adding custom claims to the user and let these get added to the access token. Then you can use the API to add/change/remove claims from the user.
But indeed: other OIDCs allow javascript / custom code to implement this.