starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 09:13:19 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #533] [MERGED] Changes to feat/proxy-frontend #744

New Issue
Closed
opened 2025-10-07 00:21:37 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:21:37 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/533
Author: @ItalyPaleAle
Created: 5/14/2025
Status: ✅ Merged
Merged: 5/17/2025
Merged by: @stonith404

Base: feat/proxy-frontend ← Head: proxy-frontend-patch1

📝 Commits (6)

  • b93c3a5 Update Dockerfile:
  • ebf33e7 rename PUBLIC_APP_URL to APP_URL
  • 2efacaf change port to 1411 in missing places
  • 489c902 use APP_URL in id and access tokens as issuer in e2e tests
  • eb4ffd9 Address review feedback
  • ec0d453 Merge branch 'feat/proxy-frontend' into proxy-frontend-patch1

📊 Changes

15 files changed (+121 additions, -88 deletions)

View changed files

📝 .env.example (+1 -1)
📝 .github/workflows/e2e-tests.yml (+2 -2)
📝 Dockerfile (+19 -22)
📝 backend/.env.example (+2 -2)
📝 backend/internal/common/env_config.go (+5 -5)
📝 docker-compose.yml (+3 -3)
📝 frontend/.env.example (+1 -1)
📝 frontend/playwright.config.ts (+1 -1)
📝 frontend/tests/data.ts (+0 -30)
📝 frontend/tests/oidc.spec.ts (+8 -6)
📝 frontend/tests/utils/cleanup.util.ts (+2 -1)
➕ frontend/tests/utils/jwt.util.ts (+58 -0)
📝 frontend/vite.config.ts (+1 -1)
📝 scripts/create-one-time-access-token.sh (+3 -2)
📝 scripts/docker/entrypoint.sh (+15 -11)

📄 Description

Note: this is a PR against feat/proxy-frontend, which is #520

  1. Simplify paths: binaries are in /app and data goes in /data
    • This is another breaking change, but allows us to get rid of legacy paths /app/backend
    • Workdir in the final container is set to /, so data gets stored to /data
  2. Change port app is listening on to 1411, matching what's in docs: https://preview.pocket-id.org/docs/setup/migrate-to-v1/
    • This is an un-privileged port unlike 80, which can cause issues when the container engine itself is running as non-root.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/533 **Author:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Created:** 5/14/2025 **Status:** ✅ Merged **Merged:** 5/17/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `feat/proxy-frontend` ← **Head:** `proxy-frontend-patch1` --- ### 📝 Commits (6) - [`b93c3a5`](https://github.com/pocket-id/pocket-id/commit/b93c3a556d0d3fd821a3f30cef71889a0e8d74ba) Update Dockerfile: - [`ebf33e7`](https://github.com/pocket-id/pocket-id/commit/ebf33e7f87ff3b18e4829261b8b710c6c79cfe52) rename `PUBLIC_APP_URL` to `APP_URL` - [`2efacaf`](https://github.com/pocket-id/pocket-id/commit/2efacaf590abb675fb5d15727630ad327cdd12c2) change port to 1411 in missing places - [`489c902`](https://github.com/pocket-id/pocket-id/commit/489c902e276b4617f6245ef3c15534cfcd6cfe43) use `APP_URL` in id and access tokens as issuer in e2e tests - [`eb4ffd9`](https://github.com/pocket-id/pocket-id/commit/eb4ffd97a594ac46b2fd9977b78573319898c091) Address review feedback - [`ec0d453`](https://github.com/pocket-id/pocket-id/commit/ec0d4532b95d71dd50c832291dfd94f94d34de00) Merge branch 'feat/proxy-frontend' into proxy-frontend-patch1 ### 📊 Changes **15 files changed** (+121 additions, -88 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+1 -1) 📝 `.github/workflows/e2e-tests.yml` (+2 -2) 📝 `Dockerfile` (+19 -22) 📝 `backend/.env.example` (+2 -2) 📝 `backend/internal/common/env_config.go` (+5 -5) 📝 `docker-compose.yml` (+3 -3) 📝 `frontend/.env.example` (+1 -1) 📝 `frontend/playwright.config.ts` (+1 -1) 📝 `frontend/tests/data.ts` (+0 -30) 📝 `frontend/tests/oidc.spec.ts` (+8 -6) 📝 `frontend/tests/utils/cleanup.util.ts` (+2 -1) ➕ `frontend/tests/utils/jwt.util.ts` (+58 -0) 📝 `frontend/vite.config.ts` (+1 -1) 📝 `scripts/create-one-time-access-token.sh` (+3 -2) 📝 `scripts/docker/entrypoint.sh` (+15 -11) </details> ### 📄 Description **Note: this is a PR against [feat/proxy-frontend](https://github.com/pocket-id/pocket-id/tree/feat/proxy-frontend), which is #520** 1. Simplify paths: binaries are in /app and data goes in /data - This is another breaking change, but allows us to get rid of legacy paths /app/backend - Workdir in the final container is set to `/`, so data gets stored to `/data` 3. Change port app is listening on to 1411, matching what's in docs: https://preview.pocket-id.org/docs/setup/migrate-to-v1/ - This is an un-privileged port unlike 80, which can cause issues when the container engine itself is running as non-root. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:21:37 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#744
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?