[PR #582] [MERGED] fix: small fixes in analytics_job #717

New Issue

OVERLORD · 2025-10-07T00:21:10+03:00

OVERLORD commented

2025-10-07 00:21:10 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/582
Author: @ItalyPaleAle
Created: 5/28/2025
Status: ✅ Merged
Merged: 5/28/2025
Merged by: @kmendell

Base: main ← Head: analytics-fix

📝 Commits (2)

acfbed3 fix: small fixes in analytics_job
4128dbe Merge branch 'main' into analytics-fix

📊 Changes

3 files changed (+43 additions, -17 deletions)

View changed files

📝 backend/go.mod (+1 -0)
📝 backend/go.sum (+2 -0)
📝 backend/internal/job/analytics_job.go (+40 -17)

📄 Description

Ensure there's a timeout in the HTTP request (using a context with timeout). The HTTP client passed doesn't have a timeout, so in certain cases the operation could block forever.
Skip registering the job entirely if analytics are disabled
Add a retry (with backoff) to handle transient failures

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/582 **Author:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Created:** 5/28/2025 **Status:** ✅ Merged **Merged:** 5/28/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `analytics-fix` --- ### 📝 Commits (2) - [`acfbed3`](https://github.com/pocket-id/pocket-id/commit/acfbed3744899edfb906ac7c49f62fef25068418) fix: small fixes in analytics_job - [`4128dbe`](https://github.com/pocket-id/pocket-id/commit/4128dbe9e0dff6582792d51bb6bb89edab5f8de1) Merge branch 'main' into analytics-fix ### 📊 Changes **3 files changed** (+43 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `backend/go.mod` (+1 -0) 📝 `backend/go.sum` (+2 -0) 📝 `backend/internal/job/analytics_job.go` (+40 -17) </details> ### 📄 Description 1. Ensure there's a timeout in the HTTP request (using a context with timeout). The HTTP client passed doesn't have a timeout, so in certain cases the operation could block forever. 2. Skip registering the job entirely if analytics are disabled 3. Add a retry (with backoff) to handle transient failures --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-07 00:21:10 +03:00

OVERLORD closed this issue

2025-10-07 00:21:13 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id#717