starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 09:13:19 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #678] fix: remove duplicate request logging #672

New Issue
Closed
opened 2025-10-07 00:20:23 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:20:23 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/pocket-id/pocket-id/pull/678

State: closed
Merged: Yes

Gin's default engine constructor already adds the logger by default: https://github.com/gin-gonic/gin/blob/v1.10.0/gin.go#L224

I noticed requests being logged twice in the logs and found some related issues in the Gin repo. This may be related to #294 where the user noticed excessive logging.

Before:

❯ xh http://localhost:1411/healthz
HTTP/1.1 204 No Content
Date: Tue, 24 Jun 2025 07:46:20 GMT

[GIN] 2025/06/24 - 08:46:20 | 204 |         917ns |       127.0.0.1 | GET      "/healthz"
[GIN] 2025/06/24 - 08:46:20 | 204 |      33.791µs |       127.0.0.1 | GET      "/healthz"

After:

❯ xh http://localhost:1411/healthz
HTTP/1.1 204 No Content
Date: Tue, 24 Jun 2025 07:47:19 GMT

[GIN] 2025/06/24 - 08:47:19 | 204 |      14.958µs |       127.0.0.1 | GET      "/healthz"
**Original Pull Request:** https://github.com/pocket-id/pocket-id/pull/678 **State:** closed **Merged:** Yes --- Gin's default engine constructor already adds the logger by default: https://github.com/gin-gonic/gin/blob/v1.10.0/gin.go#L224 --- I noticed requests being logged twice in the logs and found some related issues in the Gin repo. This may be related to #294 where the user noticed excessive logging. Before: ``` ❯ xh http://localhost:1411/healthz HTTP/1.1 204 No Content Date: Tue, 24 Jun 2025 07:46:20 GMT [GIN] 2025/06/24 - 08:46:20 | 204 | 917ns | 127.0.0.1 | GET "/healthz" [GIN] 2025/06/24 - 08:46:20 | 204 | 33.791µs | 127.0.0.1 | GET "/healthz" ``` After: ``` ❯ xh http://localhost:1411/healthz HTTP/1.1 204 No Content Date: Tue, 24 Jun 2025 07:47:19 GMT [GIN] 2025/06/24 - 08:47:19 | 204 | 14.958µs | 127.0.0.1 | GET "/healthz" ```
OVERLORD added the pull-request label 2025-10-07 00:20:24 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#672
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?