[PR #696] [MERGED] fix: app config forms not updating with latest values #657

Closed
opened 2025-10-07 00:20:08 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/696
Author: @kmendell
Created: 6/29/2025
Status: Merged
Merged: 6/29/2025
Merged by: @stonith404

Base: mainHead: fix/non-reactive-form


📝 Commits (2)

  • f4f8509 fix: appConfig forms not updating with latest values
  • dd4f7ca Merge branch 'main' into fix/non-reactive-form

📊 Changes

4 files changed (+4 additions, -4 deletions)

View changed files

📝 frontend/src/routes/settings/admin/application-configuration/forms/accent-color-picker.svelte (+1 -1)
📝 frontend/src/routes/settings/admin/application-configuration/forms/app-config-email-form.svelte (+1 -1)
📝 frontend/src/routes/settings/admin/application-configuration/forms/app-config-general-form.svelte (+1 -1)
📝 frontend/src/routes/settings/admin/application-configuration/forms/app-config-ldap-form.svelte (+1 -1)

📄 Description

Fixes: https://github.com/pocket-id/pocket-id/issues/693

The forms were being created with the initial load information and the child components were never getting the updated store values.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/696 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 6/29/2025 **Status:** ✅ Merged **Merged:** 6/29/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `fix/non-reactive-form` --- ### 📝 Commits (2) - [`f4f8509`](https://github.com/pocket-id/pocket-id/commit/f4f85094d671a337b296ff44a516682d4e525934) fix: appConfig forms not updating with latest values - [`dd4f7ca`](https://github.com/pocket-id/pocket-id/commit/dd4f7ca2832ec78081273235bf50b961ed820c61) Merge branch 'main' into fix/non-reactive-form ### 📊 Changes **4 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/routes/settings/admin/application-configuration/forms/accent-color-picker.svelte` (+1 -1) 📝 `frontend/src/routes/settings/admin/application-configuration/forms/app-config-email-form.svelte` (+1 -1) 📝 `frontend/src/routes/settings/admin/application-configuration/forms/app-config-general-form.svelte` (+1 -1) 📝 `frontend/src/routes/settings/admin/application-configuration/forms/app-config-ldap-form.svelte` (+1 -1) </details> ### 📄 Description Fixes: https://github.com/pocket-id/pocket-id/issues/693 The forms were being created with the initial load information and the child components were never getting the updated store values. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:20:08 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#657