starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 09:13:19 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #714] [MERGED] fix: support non UTF-8 LDAP IDs #647

New Issue
Closed
opened 2025-10-07 00:19:58 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:19:58 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/714
Author: @stonith404
Created: 7/3/2025
Status: ✅ Merged
Merged: 7/4/2025
Merged by: @stonith404

Base: main ← Head: fix/non-utf8-lldap-ids

📝 Commits (4)

  • 3373795 fix: support non UTF-8 LDAP IDs
  • 6352748 update LDAP group sync to use correct LdapID variable
  • 80db947 fix lint issues
  • 5cd8aef improve convertLdapIdToString description

📊 Changes

2 files changed (+57 additions, -3 deletions)

View changed files

📝 backend/internal/service/ldap_service.go (+24 -3)
📝 backend/internal/service/ldap_service_test.go (+33 -0)

📄 Description

Fixes #711.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/714 **Author:** [@stonith404](https://github.com/stonith404) **Created:** 7/3/2025 **Status:** ✅ Merged **Merged:** 7/4/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `fix/non-utf8-lldap-ids` --- ### 📝 Commits (4) - [`3373795`](https://github.com/pocket-id/pocket-id/commit/3373795c0491ffc4ca92acf02c2fd9a1bf32a916) fix: support non UTF-8 LDAP IDs - [`6352748`](https://github.com/pocket-id/pocket-id/commit/63527486be392fc473fb6806a62dad99f64edcfb) update LDAP group sync to use correct LdapID variable - [`80db947`](https://github.com/pocket-id/pocket-id/commit/80db9472ef5c157a9e3c1dc8e56229cee84a6c9d) fix lint issues - [`5cd8aef`](https://github.com/pocket-id/pocket-id/commit/5cd8aef177dd68753b486ccc87f8f66ef9c408e6) improve convertLdapIdToString description ### 📊 Changes **2 files changed** (+57 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/service/ldap_service.go` (+24 -3) 📝 `backend/internal/service/ldap_service_test.go` (+33 -0) </details> ### 📄 Description Fixes #711. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:19:58 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#647
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?