starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 09:13:19 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #783] [MERGED] fix: delete WebAuthn registration session after use #616

New Issue
Closed
opened 2025-10-07 00:19:29 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:19:29 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/783
Author: @ItalyPaleAle
Created: 7/26/2025
Status: ✅ Merged
Merged: 7/27/2025
Merged by: @kmendell

Base: main ← Head: delete-signup-session

📝 Commits (1)

  • de21792 fix: delete WebAuthn registration session after use

📊 Changes

1 file changed (+13 additions, -11 deletions)

View changed files

📝 backend/internal/service/webauthn_service.go (+13 -11)

📄 Description

During the WebAuthn registration process, make sure to delete the session after it's verified and the passkey is saved. This prevents the same session from being used twice.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/783 **Author:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Created:** 7/26/2025 **Status:** ✅ Merged **Merged:** 7/27/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `delete-signup-session` --- ### 📝 Commits (1) - [`de21792`](https://github.com/pocket-id/pocket-id/commit/de21792c6393e8d25322bf91ccaf36b3bf9cb090) fix: delete WebAuthn registration session after use ### 📊 Changes **1 file changed** (+13 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/service/webauthn_service.go` (+13 -11) </details> ### 📄 Description During the WebAuthn registration process, make sure to delete the session after it's verified and the passkey is saved. This prevents the same session from being used twice. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:19:29 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#616
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?