[PR #840] [MERGED] feat: support for url based icons #589

New Issue

OVERLORD · 2025-10-07T00:18:59+03:00

OVERLORD commented

2025-10-07 00:18:59 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/840
Author: @kmendell
Created: 8/17/2025
Status: ✅ Merged
Merged: 9/29/2025
Merged by: @kmendell

Base: main ← Head: feat/self-host-icons

📝 Commits (10+)

57a48eb feat: selfhosted icons support for oidc clients
ba4ddc3 clean up oidc cliet form
2fe21b2 use icon serach logic instead of disabling file uploads
6749439 harden backend image url download function
271fb66 Merge branch 'main' into feat/self-host-icons
18dbffb split up download function to make easier to read
78363d5 Merge branch 'main' into feat/self-host-icons
4a11b35 fix linters
a0c9bf2 Merge branch 'main' into feat/self-host-icons
75e6e93 switch to url based icons, still not working to download the icon , just throws context cancled...

📊 Changes

19 files changed (+638 additions, -430 deletions)

View changed files

📝 backend/internal/bootstrap/services_bootstrap.go (+1 -1)
📝 backend/internal/common/env_config.go (+20 -0)
📝 backend/internal/dto/oidc_dto.go (+2 -0)
📝 backend/internal/model/oidc.go (+4 -9)
📝 backend/internal/service/geolite_service.go (+11 -94)
➖ backend/internal/service/geolite_service_test.go (+0 -220)
📝 backend/internal/service/oidc_service.go (+125 -49)
📝 backend/internal/utils/file_util.go (+29 -0)
➕ backend/internal/utils/ip_util.go (+87 -0)
➕ backend/internal/utils/ip_util_test.go (+159 -0)
📝 frontend/messages/en.json (+3 -1)
➕ frontend/src/lib/components/form/url-file-input.svelte (+85 -0)
📝 frontend/src/lib/components/image-box.svelte (+16 -1)
📝 frontend/src/lib/types/oidc.type.ts (+2 -1)
📝 frontend/src/routes/settings/admin/application-configuration/forms/app-config-general-form.svelte (+1 -2)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte (+33 -41)
➕ frontend/src/routes/settings/admin/oidc-clients/oidc-client-image-input.svelte (+44 -0)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-client-list.svelte (+15 -10)
📝 frontend/src/routes/settings/apps/authorized-oidc-client-card.svelte (+1 -1)

📄 Description

This adds support for oidc client logos to be retrived from a URL vs a file upload.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/840 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 8/17/2025 **Status:** ✅ Merged **Merged:** 9/29/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `feat/self-host-icons` --- ### 📝 Commits (10+) - [`57a48eb`](https://github.com/pocket-id/pocket-id/commit/57a48eb4c2be979652ba8e9f3be2aa9021842370) feat: selfhosted icons support for oidc clients - [`ba4ddc3`](https://github.com/pocket-id/pocket-id/commit/ba4ddc3c5792793ad8a7fc8d9d3b311d357e29b9) clean up oidc cliet form - [`2fe21b2`](https://github.com/pocket-id/pocket-id/commit/2fe21b27d17628bbed19f069b5d5369d836e4ed0) use icon serach logic instead of disabling file uploads - [`6749439`](https://github.com/pocket-id/pocket-id/commit/67494396003b8939fdfca61783abe1d0d005f998) harden backend image url download function - [`271fb66`](https://github.com/pocket-id/pocket-id/commit/271fb66233ed36c72efeadf16009516ebd410e7c) Merge branch 'main' into feat/self-host-icons - [`18dbffb`](https://github.com/pocket-id/pocket-id/commit/18dbffb1e35d6002b35953ff3c504b366d3fedd9) split up download function to make easier to read - [`78363d5`](https://github.com/pocket-id/pocket-id/commit/78363d54d313baaac00ca9da5d42cec1ec0ab6f6) Merge branch 'main' into feat/self-host-icons - [`4a11b35`](https://github.com/pocket-id/pocket-id/commit/4a11b35a1d4c22e4e329598ad2497cb3a70291e2) fix linters - [`a0c9bf2`](https://github.com/pocket-id/pocket-id/commit/a0c9bf2a206e43fe886fedd5c263b663a9e2dc15) Merge branch 'main' into feat/self-host-icons - [`75e6e93`](https://github.com/pocket-id/pocket-id/commit/75e6e9394934dfcf64549ab1308d55192de9b3a7) switch to url based icons, still not working to download the icon , just throws context cancled... ### 📊 Changes **19 files changed** (+638 additions, -430 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/bootstrap/services_bootstrap.go` (+1 -1) 📝 `backend/internal/common/env_config.go` (+20 -0) 📝 `backend/internal/dto/oidc_dto.go` (+2 -0) 📝 `backend/internal/model/oidc.go` (+4 -9) 📝 `backend/internal/service/geolite_service.go` (+11 -94) ➖ `backend/internal/service/geolite_service_test.go` (+0 -220) 📝 `backend/internal/service/oidc_service.go` (+125 -49) 📝 `backend/internal/utils/file_util.go` (+29 -0) ➕ `backend/internal/utils/ip_util.go` (+87 -0) ➕ `backend/internal/utils/ip_util_test.go` (+159 -0) 📝 `frontend/messages/en.json` (+3 -1) ➕ `frontend/src/lib/components/form/url-file-input.svelte` (+85 -0) 📝 `frontend/src/lib/components/image-box.svelte` (+16 -1) 📝 `frontend/src/lib/types/oidc.type.ts` (+2 -1) 📝 `frontend/src/routes/settings/admin/application-configuration/forms/app-config-general-form.svelte` (+1 -2) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte` (+33 -41) ➕ `frontend/src/routes/settings/admin/oidc-clients/oidc-client-image-input.svelte` (+44 -0) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-client-list.svelte` (+15 -10) 📝 `frontend/src/routes/settings/apps/authorized-oidc-client-card.svelte` (+1 -1) </details> ### 📄 Description This adds support for oidc client logos to be retrived from a URL vs a file upload. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-07 00:18:59 +03:00

OVERLORD closed this issue

2025-10-07 00:19:02 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id#589