starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 17:23:22 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #854] [MERGED] fix: move audit log call before TX is committed #580

New Issue
Closed
opened 2025-10-07 00:18:52 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:18:52 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/854
Author: @ItalyPaleAle
Created: 8/20/2025
Status: ✅ Merged
Merged: 8/21/2025
Merged by: @kmendell

Base: main ← Head: fix-audit-log

📝 Commits (1)

  • 479a2c1 fix: move audit log call before TX is committed

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 backend/internal/service/webauthn_service.go (+2 -2)

📄 Description

Partially reverts fe003b927c . Calls to CreateNewSignInWithEmail accept a transaction, so they should be made before the tx is committed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/854 **Author:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Created:** 8/20/2025 **Status:** ✅ Merged **Merged:** 8/21/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `fix-audit-log` --- ### 📝 Commits (1) - [`479a2c1`](https://github.com/pocket-id/pocket-id/commit/479a2c14c4a204a276d40eee4b1aca22d9375756) fix: move audit log call before TX is committed ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/service/webauthn_service.go` (+2 -2) </details> ### 📄 Description Partially reverts fe003b927ce7772692439992860c804de89ce424 . Calls to `CreateNewSignInWithEmail` accept a transaction, so they should be made before the tx is committed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:18:52 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#580
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?