[PR #898] [MERGED] feat: user display name #554

New Issue

OVERLORD · 2025-10-07T00:18:25+03:00

OVERLORD commented

2025-10-07 00:18:25 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/898
Author: @kmendell
Created: 8/29/2025
Status: ✅ Merged
Merged: 9/17/2025
Merged by: @stonith404

Base: main ← Head: feat/display-name

📝 Commits (10+)

97b9b5b feat: user display name
9389d45 add display name to tests
121381d add display name to table
9d03760 remove commented code
8924035 dont trim on get data
1ec6e44 dont trim on get data pt 2
b355b94 Merge branch 'main' into feat/display-name
03e1a3a use firstname + lastname as default value for display name
39e6fd9 adapt e2e tests
6d51204 fix type errors

📊 Changes

32 files changed (+280 additions, -112 deletions)

View changed files

📝 backend/internal/dto/app_config_dto.go (+1 -0)
📝 backend/internal/dto/user_dto.go (+11 -9)
📝 backend/internal/dto/user_dto_test.go (+36 -21)
📝 backend/internal/model/app_config.go (+1 -0)
📝 backend/internal/model/user.go (+18 -10)
📝 backend/internal/service/app_config_service.go (+1 -0)
📝 backend/internal/service/custom_claim_service.go (+1 -0)
📝 backend/internal/service/e2etest_service.go (+12 -10)
📝 backend/internal/service/ldap_service.go (+8 -6)
📝 backend/internal/service/oidc_service.go (+9 -7)
📝 backend/internal/service/user_service.go (+19 -15)
📝 backend/internal/utils/ptr_util.go (+8 -0)
➕ backend/resources/migrations/postgres/20250829120000_user_display_name.down.sql (+1 -0)
➕ backend/resources/migrations/postgres/20250829120000_user_display_name.up.sql (+6 -0)
➕ backend/resources/migrations/sqlite/20250829120000_user_display_name.down.sql (+3 -0)
➕ backend/resources/migrations/sqlite/20250829120000_user_display_name.up.sql (+42 -0)
📝 frontend/messages/en.json (+4 -1)
📝 frontend/src/lib/components/signup/signup-form.svelte (+2 -1)
📝 frontend/src/lib/types/application-configuration.ts (+1 -0)
📝 frontend/src/lib/types/user.type.ts (+2 -1)

...and 12 more files

📄 Description

Fixes: https://github.com/pocket-id/pocket-id/issues/814

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/898 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 8/29/2025 **Status:** ✅ Merged **Merged:** 9/17/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `feat/display-name` --- ### 📝 Commits (10+) - [`97b9b5b`](https://github.com/pocket-id/pocket-id/commit/97b9b5b1ac3e57e7f1952492784be2a66b364e39) feat: user display name - [`9389d45`](https://github.com/pocket-id/pocket-id/commit/9389d4501170987006b3340003c51b1e5b7e7ab6) add display name to tests - [`121381d`](https://github.com/pocket-id/pocket-id/commit/121381d06127399bf93a2f6eced4d12a921e577d) add display name to table - [`9d03760`](https://github.com/pocket-id/pocket-id/commit/9d03760ae49ad03dc2ff7c18e08985e23de41268) remove commented code - [`8924035`](https://github.com/pocket-id/pocket-id/commit/8924035f18cbe5d505a5c76bea26dffd234c2b75) dont trim on get data - [`1ec6e44`](https://github.com/pocket-id/pocket-id/commit/1ec6e4403ff3f10200d21ee638a551c23403981d) dont trim on get data pt 2 - [`b355b94`](https://github.com/pocket-id/pocket-id/commit/b355b94390f5e101cbed52e090958142daa18251) Merge branch 'main' into feat/display-name - [`03e1a3a`](https://github.com/pocket-id/pocket-id/commit/03e1a3a25270ece65574d33a0340eb73c2168721) use firstname + lastname as default value for display name - [`39e6fd9`](https://github.com/pocket-id/pocket-id/commit/39e6fd94fd9da6f1c59deb4620ba44341d4be3c0) adapt e2e tests - [`6d51204`](https://github.com/pocket-id/pocket-id/commit/6d51204832bba71a23900a09237034f82a411d3a) fix type errors ### 📊 Changes **32 files changed** (+280 additions, -112 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/dto/app_config_dto.go` (+1 -0) 📝 `backend/internal/dto/user_dto.go` (+11 -9) 📝 `backend/internal/dto/user_dto_test.go` (+36 -21) 📝 `backend/internal/model/app_config.go` (+1 -0) 📝 `backend/internal/model/user.go` (+18 -10) 📝 `backend/internal/service/app_config_service.go` (+1 -0) 📝 `backend/internal/service/custom_claim_service.go` (+1 -0) 📝 `backend/internal/service/e2etest_service.go` (+12 -10) 📝 `backend/internal/service/ldap_service.go` (+8 -6) 📝 `backend/internal/service/oidc_service.go` (+9 -7) 📝 `backend/internal/service/user_service.go` (+19 -15) 📝 `backend/internal/utils/ptr_util.go` (+8 -0) ➕ `backend/resources/migrations/postgres/20250829120000_user_display_name.down.sql` (+1 -0) ➕ `backend/resources/migrations/postgres/20250829120000_user_display_name.up.sql` (+6 -0) ➕ `backend/resources/migrations/sqlite/20250829120000_user_display_name.down.sql` (+3 -0) ➕ `backend/resources/migrations/sqlite/20250829120000_user_display_name.up.sql` (+42 -0) 📝 `frontend/messages/en.json` (+4 -1) 📝 `frontend/src/lib/components/signup/signup-form.svelte` (+2 -1) 📝 `frontend/src/lib/types/application-configuration.ts` (+1 -0) 📝 `frontend/src/lib/types/user.type.ts` (+2 -1) _...and 12 more files_ </details> ### 📄 Description Fixes: https://github.com/pocket-id/pocket-id/issues/814 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-07 00:18:25 +03:00

OVERLORD closed this issue

2025-10-07 00:18:26 +03:00

OVERLORD referenced this issue

2025-10-07 00:21:25 +03:00

[PR #554] [MERGED] feat: polish translations #731

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id#554