starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 09:13:19 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #938] [MERGED] feat: add PWA support #535

New Issue
Closed
opened 2025-10-07 00:18:05 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:18:05 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/938
Author: @stonith404
Created: 9/12/2025
Status: ✅ Merged
Merged: 9/12/2025
Merged by: @kmendell

Base: main ← Head: feat/pwa-icon

📝 Commits (2)

📊 Changes

5 files changed (+41 additions, -0 deletions)

View changed files

📝 frontend/src/app.html (+2 -0)
➕ frontend/static/app.webmanifest (+27 -0)
➕ frontend/static/img/static-logo-512.png (+0 -0)
➕ frontend/static/img/static-logo-rounded-512.png (+0 -0)
➕ frontend/static/img/static-logo.svg (+12 -0)

📄 Description

This PR makes it possible to install Pocket ID as a PWA. While it’s not a “full” PWA since we don’t use service workers, Pocket ID can now be installed from the browser onto the home screen or desktop.

The PWA’s icon and name are static, meaning that custom logos or names set in Pocket ID won’t be reflected in the installed app. Since this feature is expected to be rarely used, there’s no strong reason to add complexity by generating the manifest dynamically or converting uploaded logos into multiple formats and sizes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/938 **Author:** [@stonith404](https://github.com/stonith404) **Created:** 9/12/2025 **Status:** ✅ Merged **Merged:** 9/12/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `feat/pwa-icon` --- ### 📝 Commits (2) - [`a98d08e`](https://github.com/pocket-id/pocket-id/commit/a98d08e8f8fc2a0ca55438608bae89740fd50531) feat: add PWA icons - [`1d84e5b`](https://github.com/pocket-id/pocket-id/commit/1d84e5b329b011a30217c4b76eb65bee90271205) compress images ### 📊 Changes **5 files changed** (+41 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/app.html` (+2 -0) ➕ `frontend/static/app.webmanifest` (+27 -0) ➕ `frontend/static/img/static-logo-512.png` (+0 -0) ➕ `frontend/static/img/static-logo-rounded-512.png` (+0 -0) ➕ `frontend/static/img/static-logo.svg` (+12 -0) </details> ### 📄 Description This PR makes it possible to install Pocket ID as a PWA. While it’s not a “full” PWA since we don’t use service workers, Pocket ID can now be installed from the browser onto the home screen or desktop. The PWA’s icon and name are static, meaning that custom logos or names set in Pocket ID won’t be reflected in the installed app. Since this feature is expected to be rarely used, there’s no strong reason to add complexity by generating the manifest dynamically or converting uploaded logos into multiple formats and sizes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:18:05 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#535
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?