[PR #971] [MERGED] fix: do not use cache=shared for in-memory SQLite #521

New Issue

OVERLORD · 2025-10-07T00:17:54+03:00

OVERLORD commented

2025-10-07 00:17:54 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/971
Author: @ItalyPaleAle
Created: 9/22/2025
Status: ✅ Merged
Merged: 9/22/2025
Merged by: @kmendell

Base: main ← Head: fix-sqlite-memory

📝 Commits (1)

11ebb4a fix: do not use cache=shared for in-memory SQLite

📊 Changes

3 files changed (+35 additions, -21 deletions)

View changed files

📝 backend/internal/bootstrap/db_bootstrap.go (+27 -12)
📝 backend/internal/bootstrap/db_bootstrap_test.go (+1 -7)
📝 backend/internal/utils/testing/database.go (+7 -2)

📄 Description

Low-priority fix, since it primarily impacts unit tests

When using an in-memory SQLite databases, if using multiple connections with cache=shared and there's a transaction blocking the database, another one will not wait and will fail to start right away

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/971 **Author:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Created:** 9/22/2025 **Status:** ✅ Merged **Merged:** 9/22/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `fix-sqlite-memory` --- ### 📝 Commits (1) - [`11ebb4a`](https://github.com/pocket-id/pocket-id/commit/11ebb4a3c4bac65d86284ab22b9aa12d93f9cbaa) fix: do not use cache=shared for in-memory SQLite ### 📊 Changes **3 files changed** (+35 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/bootstrap/db_bootstrap.go` (+27 -12) 📝 `backend/internal/bootstrap/db_bootstrap_test.go` (+1 -7) 📝 `backend/internal/utils/testing/database.go` (+7 -2) </details> ### 📄 Description Low-priority fix, since it primarily impacts unit tests When using an in-memory SQLite databases, if using multiple connections with cache=shared and there's a transaction blocking the database, another one will not wait and will fail to start right away --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-07 00:17:54 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id#521