starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 09:13:19 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

[PR #974] [CLOSED] feat: set pwa display type via environment variable #516

New Issue
Closed
opened 2025-10-07 00:17:47 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-07 00:17:47 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/974
Author: @James18232
Created: 9/22/2025
Status: ❌ Closed

Base: main ← Head: pwa_env_variable

📝 Commits (3)

  • 1a783ca feat: set pwa display type via env variable
  • 195fddf Merge branch 'pocket-id:main' into pwa_env_variable
  • ec51026 golint fix

📊 Changes

4 files changed (+29 additions, -1 deletions)

View changed files

📝 backend/frontend/frontend_included.go (+25 -0)
📝 backend/internal/common/env_config.go (+2 -0)
📝 frontend/src/app.html (+1 -0)
📝 frontend/static/app.webmanifest (+1 -1)

📄 Description

This feature allows the user to set the 'display' type to be used in the app manifest for use when saving as a PWA. The default setting retains the existing "minimal-ui" value.

based on earlier concepts by @ItalyPaleAle.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/974 **Author:** [@James18232](https://github.com/James18232) **Created:** 9/22/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `pwa_env_variable` --- ### 📝 Commits (3) - [`1a783ca`](https://github.com/pocket-id/pocket-id/commit/1a783ca7d0be249a85d14784fd93670783467347) feat: set pwa display type via env variable - [`195fddf`](https://github.com/pocket-id/pocket-id/commit/195fddfa24e083160a623c14c5af1268ec551d90) Merge branch 'pocket-id:main' into pwa_env_variable - [`ec51026`](https://github.com/pocket-id/pocket-id/commit/ec5102637348536715640b7f0c89aa6618e798ee) golint fix ### 📊 Changes **4 files changed** (+29 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/frontend/frontend_included.go` (+25 -0) 📝 `backend/internal/common/env_config.go` (+2 -0) 📝 `frontend/src/app.html` (+1 -0) 📝 `frontend/static/app.webmanifest` (+1 -1) </details> ### 📄 Description This feature allows the user to set the 'display' type to be used in the app manifest for use when saving as a PWA. The default setting retains the existing "minimal-ui" value. based on earlier concepts by @ItalyPaleAle. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-07 00:17:48 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#516
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?