[PR #993] [MERGED] feat: add required indicator for required inputs #508

New Issue

OVERLORD · 2025-10-07T00:17:43+03:00

OVERLORD commented

2025-10-07 00:17:43 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/993
Author: @stonith404
Created: 10/1/2025
Status: ✅ Merged
Merged: 10/1/2025
Merged by: @stonith404

Base: main ← Head: feat/required-fields

📝 Commits (4)

8c85540 feat: add required indicator for required inputs
61f3d44 use asterix for required fields in federated client credentials
6de083d use css to display the asterix
bb00974 generate display name in ldap service

📊 Changes

12 files changed (+66 additions, -25 deletions)

View changed files

📝 backend/internal/dto/user_dto.go (+1 -1)
📝 backend/internal/service/ldap_service.go (+5 -0)
📝 frontend/src/lib/components/form/form-input.svelte (+1 -1)
📝 frontend/src/lib/components/header/header-avatar.svelte (+1 -2)
📝 frontend/src/lib/components/ui/label/label.svelte (+12 -3)
📝 frontend/src/lib/utils/form-util.ts (+32 -4)
📝 frontend/src/routes/settings/account/account-form.svelte (+1 -1)
📝 frontend/src/routes/settings/admin/application-configuration/forms/app-config-ldap-form.svelte (+5 -5)
📝 frontend/src/routes/settings/admin/oidc-clients/federated-identities-input.svelte (+5 -5)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-client-preview-modal.svelte (+1 -1)
📝 frontend/src/routes/settings/admin/user-groups/user-selection.svelte (+1 -1)
📝 frontend/src/routes/settings/admin/users/user-form.svelte (+1 -1)

📄 Description

This PR adds an indicator to every input field that is required:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/993 **Author:** [@stonith404](https://github.com/stonith404) **Created:** 10/1/2025 **Status:** ✅ Merged **Merged:** 10/1/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `feat/required-fields` --- ### 📝 Commits (4) - [`8c85540`](https://github.com/pocket-id/pocket-id/commit/8c8554005c790927db2c169746b0221ef57e183e) feat: add required indicator for required inputs - [`61f3d44`](https://github.com/pocket-id/pocket-id/commit/61f3d44117bea4e5ce72b7c3d56d0e668027536c) use asterix for required fields in federated client credentials - [`6de083d`](https://github.com/pocket-id/pocket-id/commit/6de083d2ca729204c78fa993dc35b0b1e2958fc8) use css to display the asterix - [`bb00974`](https://github.com/pocket-id/pocket-id/commit/bb00974a8ea4ff004e2e13df206aca8b8c517ddc) generate display name in ldap service ### 📊 Changes **12 files changed** (+66 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/dto/user_dto.go` (+1 -1) 📝 `backend/internal/service/ldap_service.go` (+5 -0) 📝 `frontend/src/lib/components/form/form-input.svelte` (+1 -1) 📝 `frontend/src/lib/components/header/header-avatar.svelte` (+1 -2) 📝 `frontend/src/lib/components/ui/label/label.svelte` (+12 -3) 📝 `frontend/src/lib/utils/form-util.ts` (+32 -4) 📝 `frontend/src/routes/settings/account/account-form.svelte` (+1 -1) 📝 `frontend/src/routes/settings/admin/application-configuration/forms/app-config-ldap-form.svelte` (+5 -5) 📝 `frontend/src/routes/settings/admin/oidc-clients/federated-identities-input.svelte` (+5 -5) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-client-preview-modal.svelte` (+1 -1) 📝 `frontend/src/routes/settings/admin/user-groups/user-selection.svelte` (+1 -1) 📝 `frontend/src/routes/settings/admin/users/user-form.svelte` (+1 -1) </details> ### 📄 Description This PR adds an indicator to every input field that is required: <img width="1270" height="229" alt="Screenshot 2025-10-01 at 10 53 59" src="https://github.com/user-attachments/assets/757b35bf-8e18-462f-8a11-b123485384d4" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-07 00:17:43 +03:00

OVERLORD closed this issue

2025-10-07 00:17:43 +03:00

OVERLORD referenced this issue

2025-10-07 00:18:43 +03:00

[PR #864] [MERGED] feat: allow custom client IDs #572

OVERLORD referenced this issue

2025-10-07 00:19:06 +03:00

[PR #830] [CLOSED] feat: add ability to set custom client ID #594

OVERLORD referenced this issue

2025-10-07 00:19:11 +03:00

[PR #830] feat: add ability to set custom client ID #598