mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-06 09:13:19 +03:00
🚀 Feature: Enable PKCE by default #47
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @vanillajonathan on GitHub.
Feature description
When creating a new client the PKCE option should be enabled by default.
Pitch
To follow best practices, avoid misconfiguration, and to be secure by default.
@vanillajonathan commented on GitHub:
Similarly many OIDC clients enable PKCE by default.
c821481c64/src/Security/Authentication/OpenIdConnect/src/OpenIdConnectOptions.cs (L339)@stonith404 commented on GitHub:
Many OIDC clients don’t support PKCE. If we make PKCE the default, users who aren’t familiar with it may run into configuration problems and find that their clients don’t work. Since enabling PKCE is just a single click, it may be better to leave it as an optional setting.