mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-09 17:23:22 +03:00
🚀 Feature: if you edit as admin some users, show their groups #447
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @PaddyPat on GitHub.
Originally assigned to: @kmendell on GitHub.
Feature description
If I edit a user (user is selected), it would be nice to see all groups and easy add the user to new / other groups .
currently I must search every group and add to every group in groups menu a user
Pitch
Thanks
@PaddyPat commented on GitHub:
If I edit a existing member there is a page with
general
..
profile picture
..
custom claim
…
And I think a new headline
assigned groups (sorted by name!)
[ ] group mealie
[ ] group outline
[x] group pingvinshare
[ ] group …
Where you easy and fast see which group is assigned to one user will help.
Also it should be possible to assign in this view the selected user to groups
Like
[x] group mealie
[x] group outline
[x] group pingvinshare
[ ] group …
—
Currently I must open every group and check which user is inside..
@kmendell commented on GitHub:
@PaddyPat Could you attach a screenshot with just a outline of where you were thinking you would like to see this implemented?
@kmendell commented on GitHub:
@PaddyPat So something like this?
Just a note this isn't complete, i want to reuse the same table as other forms, but this was just faster to implement as a test.
@kmendell commented on GitHub:
This issue is seems a bit redundant since the functionaltiy is already implemented somewhere else, but If this feature request gets more likes (👍) and the demand for the feature is there, we will consider implementing it.
@kmendell commented on GitHub:
This is a better version it uses the same table, as the other forms.
You can test by using this image:
ghcr.io/kmendell/pocket-id:user-group-form@PaddyPat commented on GitHub:
@kmendell awesome, it's fine, great job, no issues.
fyi, sorting is not fixed in:
@kmendell commented on GitHub:
@PaddyPat Can you try again with the:
ghcr.io/kmendell/pocket-id:user-group-formimage?As far as the default sort count, the rest of the tables are at 10 by default, and i think this is by design. So i kept this one at 10 as well.
@kmendell commented on GitHub:
What do you mean? On the other tables in other pages? That should be handled in a sperate issue vs this one, Just for tracking purposes.
@PaddyPat commented on GitHub:
Thanks, looks fine.
please:
@kmendell commented on GitHub:
Gotcha i'll try to fix the state values of the page nation and the sorting, i'll try to fix that today, and let you know when i have pushed a updated image
@PaddyPat commented on GitHub:
If I open one of the other urls
Https://pocketid.Domain.com/settings/admin/users
Or ..
.../settings/admin/user-groups
.../settings/admin/user-groups/6a1asdf-asd-asd-asd-asdasd (users in group)
.../settings/admin/oidc-clients
The sorting is wrong. I must first select sort by FriendlyName.
It sorts fine on your fixed page but not on other urls.
Maybe it’s easy for you to fix also the other ‚tables‘
@kmendell commented on GitHub:
Oh yeah it was doing that on my user page as well but i implemented a helper function to fix that. I opened https://github.com/pocket-id/pocket-id/issues/298 for it.
@kmendell commented on GitHub:
Though I'm not sure what you mean, I'm testing the sorting , and it seems to sort just fine for my instance.