mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-06 09:13:19 +03:00
🐛 Bug Report: Animations should be a lot quicker #221
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ItalyPaleAle on GitHub.
Originally assigned to: @kmendell on GitHub.
Reproduction steps
Animations were introduced in a recent release, but they tend to be relatively slow, up to 500ms.
While they are nice, slow animations artificially slow down the UX and make the app feel slower. This was also covered in a recent Syntax episode.
Ideally all animations should be quick, 100 or 200ms at most.
Expected behavior
Animations should be 200ms or faster
Actual Behavior
Animations are slow, up to 500ms
Version and Environment
main branch
Log Output
No response
@kmendell commented on GitHub:
I set it to a max of 300ms here this should speed up the animations
d534fad1cf@kmendell commented on GitHub:
Ill work on this.
@mitchplze commented on GitHub:
Not sure if you saw but disabling animations altogether is possible with
DISABLE_ANIMATIONS=true(or UI setting) as a workaround.@ItalyPaleAle commented on GitHub:
Yes, I disabled animations in my setup. This still remains as a bug IMHO.
@kmendell commented on GitHub:
@ItalyPaleAle The timing is set to 150ms with a delay of 50ms, is there a certain spot you are seeing this take up to 500ms?
@kmendell commented on GitHub:
I did 300 over 200 as 200 was almost instant, 300 is still fast and still looks decent.
@kmendell commented on GitHub:
If users want the instant look they can be disabled, can you try the latest fi in the v1.0.0 branch and see if it's better? I updated the fade wrapper, which is the main thing that was updated with the animation update. A lot of the others ones already existed before I made the UI Changes
@ItalyPaleAle commented on GitHub:
@kmendell thanks but I think i see a lot of slower animations, for example:
d6104bbb35/frontend/src/routes/authorize/components/client-provider-images.svelte (L25)d6104bbb35/frontend/src/routes/authorize/components/client-provider-images.svelte (L34)d6104bbb35/frontend/src/routes/authorize/components/client-provider-images.svelte (L42)d6104bbb35/frontend/src/routes/authorize/components/client-provider-images.svelte (L47)d6104bbb35/frontend/src/routes/login/components/login-logo-error-success-indicator.svelte (L17)d6104bbb35/frontend/src/lib/components/fade-wrapper.svelte (L51)d6104bbb35/frontend/src/app.css (L117-L118)d6104bbb35/frontend/src/app.css (L72)Almost instant is what we want IMHO! Users should not perceive the delay