mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-09 17:23:22 +03:00
🚀 Feature: Alternative to PORT variable for configuring frontend listening port #219
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @michaelbeaumont on GitHub.
Feature description
Add FRONTEND_PORT instead of PORT for configuring the frontend's listening port.
Pitch
I'm trying to deploy
pocket-idon Digital Ocean's app platform. Each docker container that runs gets to choose one "public HTTP port." In the case ofpocket-idthis should be the same asCADDY_PORT. Unfortunately, when choosing this port, Digital Ocean overrides the PORT variable. I don't know why. But the consequence of this is that only the frontend is ever reachable. Trying to setCADDY_PORTto be the same as the "public HTTP port" means changingPORT, which means an address/port conflict between the frontend and Caddy.This is really bad UX from Digital Ocean so I would understand not working around it but at the moment this makes the upstream docker image unusable with DO's app platform
EDIT: apparently overriding PORT is a common workflow for PaaS 🤷
@kmendell commented on GitHub:
This is something we are already working on for another refactor and is apart of https://github.com/pocket-id/pocket-id/pull/520
CADDY_PORT is going away and only PORT will exist.
@michaelbeaumont commented on GitHub:
Closing this cause I've tested the image built from the above PR and it works! Thanks @kmendell