mirror of
https://github.com/pocket-id/pocket-id.git
synced 2025-12-06 09:13:19 +03:00
🐛 Bug Report: CORS error for accessing the userinfo endpoint using a web client #184
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @simonfranken on GitHub.
Reproduction steps
Public ClientandPKCE Enabled.Authorizationheader.Authorizationheader due to a CORS error.Expected behavior
The Pocket ID should permit the Authorization header to be included at the very least for clients that are configured as Public.
I conducted the following tests:
Access-Control-Allow-Headers: *header to all responses. This header resolves the issue in my specific case. However, it is important to note that this is merely a workaround, as the inclusion of this header should not be applied to all responses.Actual Behavior
Pocket ID sends a response, which does not allow the
Authorizationheader.Version and Environment
v1.0
Log Output
No response
@bfqrst commented on GitHub:
Thanks @stonith404, that did the trick for me! CORS error is gone, Netbird is able to pull the name, email and avatar! LGTM!
@bfqrst commented on GitHub:
I suppose the :next tag is not updated yet?
@stonith404 commented on GitHub:
This should be fixed with
b9489b5e9a. Could you test theghcr.io/pocket-id/pocket-id:nextimage and let me know if it works now. Just to make sure that I don't have to whitelist more headers.@stonith404 commented on GitHub:
Oh yeah sorry. Should be ready now.
@bfqrst commented on GitHub:
I think I also had this happen to me in conjunction with a Netbird selfhosted installation. I'll try this as well to see if it changes something...
@stonith404 commented on GitHub:
Thanks for testing this so quickly. This should be fixed in
v1.2.0.@simonfranken commented on GitHub:
@stonith404 Thanks for the quick reply! I can confirm that it works just fine on my end.