starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 09:13:19 +03:00
Code Issues 121 Packages Projects Releases 16 Wiki Activity

🐛 Bug Report: LDAP_ATTRIBUTE_ADMIN_GROUP is misnamed #177

New Issue
Open
opened 2025-10-07 00:04:42 +03:00 by OVERLORD · 1 comment
OVERLORD commented 2025-10-07 00:04:42 +03:00
Owner
Copy Link

Originally created by @dougmeredith on GitHub.

Reproduction steps

This might be more of a deficiency than a bug, but I didn't have that option to select.

The configuration item LDAP_ATTRIBUTE_ADMIN_GROUP is not an attribute name, it's the name of a group. It should be called "LDAP_ADMIN_GROUP" or something like that.

Expected behavior

Only attributes should begin with "LDAP_ATTRIBUTE_".

Actual Behavior

A non-attribute begins with "LDAP_ATTRIBUTE_".

Version and Environment

v1.2.0

Log Output

No response

Originally created by @dougmeredith on GitHub. ### Reproduction steps This might be more of a deficiency than a bug, but I didn't have that option to select. The configuration item LDAP_ATTRIBUTE_ADMIN_GROUP is not an attribute name, it's the name of a group. It should be called "LDAP_ADMIN_GROUP" or something like that. ### Expected behavior Only attributes should begin with "LDAP_ATTRIBUTE_". ### Actual Behavior A non-attribute begins with "LDAP_ATTRIBUTE_". ### Version and Environment v1.2.0 ### Log Output _No response_
OVERLORD added the breaking label 2025-10-07 00:04:42 +03:00
OVERLORD commented 2025-10-07 00:04:44 +03:00
Author
Owner
Copy Link

@stonith404 commented on GitHub:

Thank you for reporting this. I have updated the description in the documentation, but since renaming this variable would break existing installations, we will wait to fix it until the next major release.

@stonith404 commented on GitHub: Thank you for reporting this. I have updated the description in the documentation, but since renaming this variable would break existing installations, we will wait to fix it until the next major release.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label breaking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#177
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?