🚀 Feat: UX improvements for client options #12

New Issue

OVERLORD · 2025-10-06T23:58:10+03:00

OVERLORD commented

2025-10-06 23:58:10 +03:00

Originally created by @James18232 on GitHub.

Feature description

Adding as a feature as this is not exactly a bug.

The client options page should be updated to change the functionality to:

hide (or grey out) the PCKE toggle from the user if the public toggle is selected; and
switch the opposite toggle (PKCE or Public) on/off as applicable so that one is the inverse of the other

Pitch

The current options are potentially confusing, given these options actually relate to two different authentication flows which can be adopted (public client flow vs standard authorisation flow with optional PKCE extension).

If the public toggle is used, PKCE is used by default for the public client flow. Users may get confused and think both the public and PKCE toggles are required to be checked to use a public flow for that client.

This may need a migration to handle existing clients that have both the client and pkce toggled on (the pkce can be turned off), not that i believe this has any impact on current functionality.

This will result in either the user checking pkce to use the optional extension, with the public toggle automatically turned off (or greyed out?), or the user checks public and the PKCE toggle is automatically turned off and hidden from view (or alternatively greyed out)..

Originally created by @James18232 on GitHub. ### Feature description Adding as a feature as this is not exactly a bug. The client options page should be updated to change the functionality to: 1. hide (or grey out) the PCKE toggle from the user if the public toggle is selected; and 2. switch the opposite toggle (PKCE or Public) on/off as applicable so that one is the inverse of the other ### Pitch The current options are potentially confusing, given these options actually relate to two different authentication flows which can be adopted (public client flow vs standard authorisation flow with optional PKCE extension). If the public toggle is used, PKCE is used by default for the public client flow. Users may get confused and think both the public and PKCE toggles are required to be checked to use a public flow for that client. This may need a migration to handle existing clients that have both the client and pkce toggled on (the pkce can be turned off), not that i believe this has any impact on current functionality. This will result in either the user checking pkce to use the optional extension, with the public toggle automatically turned off (or greyed out?), or the user checks public and the PKCE toggle is automatically turned off and hidden from view (or alternatively greyed out)..

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id#12