[PR #1289] feat: allow use image of common types for favicon #1112

Open
opened 2026-02-04 21:17:36 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/1289
Author: @taoso
Created: 1/31/2026
Status: 🔄 Open

Base: mainHead: favicon


📝 Commits (3)

  • 36acccc Allow use image of common types as Favicon
  • a45ca8d Update backend/internal/common/errors.go
  • b6f21ec Update frontend/src/routes/settings/admin/application-configuration/update-application-images.svelte

📊 Changes

3 files changed (+4 additions, -4 deletions)

View changed files

📝 backend/internal/common/errors.go (+1 -1)
📝 backend/internal/controller/app_images_controller.go (+2 -2)
📝 frontend/src/routes/settings/admin/application-configuration/update-application-images.svelte (+1 -1)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/1289 **Author:** [@taoso](https://github.com/taoso) **Created:** 1/31/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `favicon` --- ### 📝 Commits (3) - [`36acccc`](https://github.com/pocket-id/pocket-id/commit/36accccebd18ed77136fb09f0374cedd2cf5ae3a) Allow use image of common types as Favicon - [`a45ca8d`](https://github.com/pocket-id/pocket-id/commit/a45ca8df0c7a3b5edd8b7c214afc6380b47bc6c2) Update backend/internal/common/errors.go - [`b6f21ec`](https://github.com/pocket-id/pocket-id/commit/b6f21ec11c27fd7b175de977ba3d0897e9630ede) Update frontend/src/routes/settings/admin/application-configuration/update-application-images.svelte ### 📊 Changes **3 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/common/errors.go` (+1 -1) 📝 `backend/internal/controller/app_images_controller.go` (+2 -2) 📝 `frontend/src/routes/settings/admin/application-configuration/update-application-images.svelte` (+1 -1) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 21:17:36 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#1112