starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2026-03-01 11:21:53 +03:00
Code Issues 61 Packages Projects Releases 11 Wiki Activity

[PR #1288] feat: allow first name and display name to be optional #1111

New Issue
Open
opened 2026-02-04 21:17:34 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 21:17:34 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/1288
Author: @taoso
Created: 1/31/2026
Status: 🔄 Open

Base: main ← Head: optional-names

📝 Commits (3)

📊 Changes

8 files changed (+57 additions, -27 deletions)

View changed files

📝 backend/internal/dto/signup_dto.go (+1 -1)
📝 backend/internal/dto/user_dto.go (+3 -3)
📝 backend/internal/dto/user_dto_test.go (+12 -2)
📝 backend/internal/model/user.go (+11 -2)
📝 frontend/src/lib/components/signup/signup-form.svelte (+4 -4)
📝 frontend/src/lib/utils/form-util.ts (+11 -0)
📝 frontend/src/routes/settings/account/account-form.svelte (+5 -5)
📝 frontend/src/routes/settings/admin/users/user-form.svelte (+10 -10)

📄 Description

In some simple scenario, it seems too cumbersome to require the First/Last/Display names.

So I propose to make all these fields optional.

BTW:

Please give advice on when to use the emptyToUndefined()

Make this fields optional is a little hard for me. Instead, I just let them accept empty string.

Thanks.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/1288 **Author:** [@taoso](https://github.com/taoso) **Created:** 1/31/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `optional-names` --- ### 📝 Commits (3) - [`791a616`](https://github.com/pocket-id/pocket-id/commit/791a6164e05f8fed898ab8ed8e214a54f4b1dd4a) Make First/Last/Display Names Optional - [`e0836b8`](https://github.com/pocket-id/pocket-id/commit/e0836b8b040e85398a546630fef4107a969dcbb6) fix frontend check - [`b34618c`](https://github.com/pocket-id/pocket-id/commit/b34618cb8a30d0403b7d652f2f6ca3f1990ef728) fix go test ### 📊 Changes **8 files changed** (+57 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/dto/signup_dto.go` (+1 -1) 📝 `backend/internal/dto/user_dto.go` (+3 -3) 📝 `backend/internal/dto/user_dto_test.go` (+12 -2) 📝 `backend/internal/model/user.go` (+11 -2) 📝 `frontend/src/lib/components/signup/signup-form.svelte` (+4 -4) 📝 `frontend/src/lib/utils/form-util.ts` (+11 -0) 📝 `frontend/src/routes/settings/account/account-form.svelte` (+5 -5) 📝 `frontend/src/routes/settings/admin/users/user-form.svelte` (+10 -10) </details> ### 📄 Description In some simple scenario, it seems too cumbersome to require the First/Last/Display names. So I propose to make all these fields optional. BTW: ~~Please give advice on when to use the `emptyToUndefined()`~~ Make this fields optional is a little hard for me. Instead, I just let them accept empty string. Thanks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 21:17:34 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
bug
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#1111
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?