starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2026-02-05 00:39:38 +03:00
Code Issues 61 Packages Projects Releases 10 Wiki Activity

[PR #1114] [MERGED] feat: remove DbProvider env variable and calculate it dynamically #1059

New Issue
Closed
opened 2026-02-04 21:14:00 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 21:14:00 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/1114
Author: @kmendell
Created: 11/26/2025
Status: ✅ Merged
Merged: 11/27/2025
Merged by: @ItalyPaleAle

Base: breaking/v2 ← Head: v2/dynamic-db-provider

📝 Commits (2)

  • 33df5fc refactor: remove DbProvider env variable and calculate it dynamically
  • 63c94dd use swicth statment

📊 Changes

3 files changed (+26 additions, -63 deletions)

View changed files

📝 backend/internal/common/env_config.go (+26 -29)
📝 backend/internal/common/env_config_test.go (+0 -33)
📝 tests/setup/docker-compose-postgres.yml (+0 -1)

📄 Description

Removes the DbProvider env variable, and calulates it dyanamically based on the connection string.

DbProvider constants were left, as well as the value in the EnvConfigSchema as its used in alot of places, as keeping that seemed easier than making a helper but im not in love with it.. and open to changing it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/1114 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 11/26/2025 **Status:** ✅ Merged **Merged:** 11/27/2025 **Merged by:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Base:** `breaking/v2` ← **Head:** `v2/dynamic-db-provider` --- ### 📝 Commits (2) - [`33df5fc`](https://github.com/pocket-id/pocket-id/commit/33df5fcd4c490d4c18fac7007aacdb782fed698b) refactor: remove DbProvider env variable and calculate it dynamically - [`63c94dd`](https://github.com/pocket-id/pocket-id/commit/63c94dddacecf8e74e2e819392363142a8a9e01d) use swicth statment ### 📊 Changes **3 files changed** (+26 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/common/env_config.go` (+26 -29) 📝 `backend/internal/common/env_config_test.go` (+0 -33) 📝 `tests/setup/docker-compose-postgres.yml` (+0 -1) </details> ### 📄 Description Removes the `DbProvider` env variable, and calulates it dyanamically based on the connection string. DbProvider constants were left, as well as the value in the EnvConfigSchema as its used in alot of places, as keeping that seemed easier than making a helper but im not in love with it.. and open to changing it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 21:14:00 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
bug
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#1059
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?