[PR #1089] [MERGED] fix!: rename LDAP_ATTRIBUTE_ADMIN_GROUP env variable to LDAP_ADMIN_GROUP_NAME #1052

Closed
opened 2026-02-04 21:13:32 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/1089
Author: @stonith404
Created: 11/11/2025
Status: Merged
Merged: 11/12/2025
Merged by: @stonith404

Base: breaking/v2Head: fix/ldap-env-variable


📝 Commits (1)

  • b00d9ff fix!: rename LDAP_ATTRIBUTE_ADMIN_GROUP env variable to LDAP_ADMIN_GROUP_NAME

📊 Changes

7 files changed (+8 additions, -8 deletions)

View changed files

📝 backend/internal/dto/app_config_dto.go (+1 -1)
📝 backend/internal/model/app_config.go (+1 -1)
📝 backend/internal/service/app_config_service.go (+1 -1)
📝 backend/internal/service/e2etest_service.go (+1 -1)
📝 backend/internal/service/ldap_service.go (+1 -1)
📝 frontend/src/lib/types/application-configuration.ts (+1 -1)
📝 frontend/src/routes/settings/admin/application-configuration/forms/app-config-ldap-form.svelte (+2 -2)

📄 Description

Fixes #619.

Breaking changes:

  • LDAP_ATTRIBUTE_ADMIN_GROUP renamed to LDAP_ADMIN_GROUP_NAME.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/1089 **Author:** [@stonith404](https://github.com/stonith404) **Created:** 11/11/2025 **Status:** ✅ Merged **Merged:** 11/12/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `breaking/v2` ← **Head:** `fix/ldap-env-variable` --- ### 📝 Commits (1) - [`b00d9ff`](https://github.com/pocket-id/pocket-id/commit/b00d9ffe5a98dc64d1bf90cfae73afb2b42978f9) fix!: rename `LDAP_ATTRIBUTE_ADMIN_GROUP` env variable to `LDAP_ADMIN_GROUP_NAME` ### 📊 Changes **7 files changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/dto/app_config_dto.go` (+1 -1) 📝 `backend/internal/model/app_config.go` (+1 -1) 📝 `backend/internal/service/app_config_service.go` (+1 -1) 📝 `backend/internal/service/e2etest_service.go` (+1 -1) 📝 `backend/internal/service/ldap_service.go` (+1 -1) 📝 `frontend/src/lib/types/application-configuration.ts` (+1 -1) 📝 `frontend/src/routes/settings/admin/application-configuration/forms/app-config-ldap-form.svelte` (+2 -2) </details> ### 📄 Description Fixes #619. Breaking changes: - `LDAP_ATTRIBUTE_ADMIN_GROUP` renamed to `LDAP_ADMIN_GROUP_NAME`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 21:13:32 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#1052