starred/pocket-id
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2026-02-05 00:39:38 +03:00
Code Issues 61 Packages Projects Releases 10 Wiki Activity

[PR #1047] [MERGED] fix: use constant time comparisons when validating PKCE challenges #1033

New Issue
Closed
opened 2026-02-04 21:12:11 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-04 21:12:11 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/1047
Author: @ItalyPaleAle
Created: 10/24/2025
Status: ✅ Merged
Merged: 10/24/2025
Merged by: @stonith404

Base: main ← Head: pkce-constant-time

📝 Commits (1)

  • 9af6455 fix: use constant time comparisons when validating PKCE challenges

📊 Changes

2 files changed (+39 additions, -7 deletions)

View changed files

📝 backend/internal/service/oidc_service.go (+12 -7)
📝 backend/internal/service/oidc_service_test.go (+27 -0)

📄 Description

This fixes a small potential timing attack

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/1047 **Author:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Created:** 10/24/2025 **Status:** ✅ Merged **Merged:** 10/24/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `pkce-constant-time` --- ### 📝 Commits (1) - [`9af6455`](https://github.com/pocket-id/pocket-id/commit/9af6455edc8c73ff3cadd6b379c888226d3feabc) fix: use constant time comparisons when validating PKCE challenges ### 📊 Changes **2 files changed** (+39 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/service/oidc_service.go` (+12 -7) 📝 `backend/internal/service/oidc_service_test.go` (+27 -0) </details> ### 📄 Description This fixes a small potential timing attack --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-04 21:12:11 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
bug
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id#1033
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?