[PR #1039] [MERGED] feat: dark mode oidc client icons #1031

New Issue

OVERLORD · 2026-02-04T21:11:56+03:00

OVERLORD commented

2026-02-04 21:11:56 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/1039
Author: @kmendell
Created: 10/18/2025
Status: ✅ Merged
Merged: 10/24/2025
Merged by: @stonith404

Base: main ← Head: feat/dark-mode-icons

📝 Commits (10+)

da59c50 feat: dark mode oidc client icons
e839ac3 update tests and labels
e9add98 fix oidc client list light/dark icon
b2617b5 e2e
613a2e0 test selectors
3552017 fix my ternaries forest fire
6f58f37 simplify controller
37871b3 use tabed layout
5711667 remove duplicated code
10535c8 use switch instead of if else

📊 Changes

19 files changed (+381 additions, -119 deletions)

View changed files

📝 backend/internal/controller/oidc_controller.go (+24 -3)
📝 backend/internal/dto/oidc_dto.go (+3 -0)
📝 backend/internal/model/oidc.go (+5 -0)
📝 backend/internal/service/oidc_service.go (+118 -24)
➕ backend/resources/migrations/postgres/20251018000000_add_dark_logo.down.sql (+1 -0)
➕ backend/resources/migrations/postgres/20251018000000_add_dark_logo.up.sql (+1 -0)
➕ backend/resources/migrations/sqlite/20251018000000_add_dark_logo.down.sql (+5 -0)
➕ backend/resources/migrations/sqlite/20251018000000_add_dark_logo.up.sql (+5 -0)
📝 frontend/src/lib/components/form/url-file-input.svelte (+6 -4)
📝 frontend/src/lib/services/oidc-service.ts (+15 -9)
📝 frontend/src/lib/types/oidc.type.ts (+5 -1)
📝 frontend/src/lib/utils/cached-image-util.ts (+45 -33)
📝 frontend/src/routes/settings/admin/application-configuration/application-image.svelte (+2 -2)
📝 frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte (+14 -2)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte (+93 -24)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-client-image-input.svelte (+24 -11)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-client-list.svelte (+4 -1)
📝 frontend/src/routes/settings/apps/authorized-oidc-client-card.svelte (+1 -1)
📝 tests/specs/oidc-client-settings.spec.ts (+10 -4)

📄 Description

Closes: https://github.com/pocket-id/pocket-id/issues/744

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/1039 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 10/18/2025 **Status:** ✅ Merged **Merged:** 10/24/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `feat/dark-mode-icons` --- ### 📝 Commits (10+) - [`da59c50`](https://github.com/pocket-id/pocket-id/commit/da59c508f2618743de31b1a450b84aa16ae3bbf0) feat: dark mode oidc client icons - [`e839ac3`](https://github.com/pocket-id/pocket-id/commit/e839ac3600d45c07a233d6d5e1ba078c0871f829) update tests and labels - [`e9add98`](https://github.com/pocket-id/pocket-id/commit/e9add98b81fac729a77f46ee2fd4b31eed0632f0) fix oidc client list light/dark icon - [`b2617b5`](https://github.com/pocket-id/pocket-id/commit/b2617b5c682e70f85c480665384384a925a86edb) e2e - [`613a2e0`](https://github.com/pocket-id/pocket-id/commit/613a2e08a677e0c6b4bb8df8ee72cf6d1fae9e0a) test selectors - [`3552017`](https://github.com/pocket-id/pocket-id/commit/35520178e4ea80fa84e0582f5c208b12b954a88d) fix my ternaries forest fire - [`6f58f37`](https://github.com/pocket-id/pocket-id/commit/6f58f374bc2933d3ab5486881bf48ac00efaafe8) simplify controller - [`37871b3`](https://github.com/pocket-id/pocket-id/commit/37871b3b4336eb65980d83dc9d16959642ea860c) use tabed layout - [`5711667`](https://github.com/pocket-id/pocket-id/commit/5711667707368f971a943a63bce9251add36c90b) remove duplicated code - [`10535c8`](https://github.com/pocket-id/pocket-id/commit/10535c80a8d0f49b8bc42d384c851ee5129b4ec1) use switch instead of if else ### 📊 Changes **19 files changed** (+381 additions, -119 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/controller/oidc_controller.go` (+24 -3) 📝 `backend/internal/dto/oidc_dto.go` (+3 -0) 📝 `backend/internal/model/oidc.go` (+5 -0) 📝 `backend/internal/service/oidc_service.go` (+118 -24) ➕ `backend/resources/migrations/postgres/20251018000000_add_dark_logo.down.sql` (+1 -0) ➕ `backend/resources/migrations/postgres/20251018000000_add_dark_logo.up.sql` (+1 -0) ➕ `backend/resources/migrations/sqlite/20251018000000_add_dark_logo.down.sql` (+5 -0) ➕ `backend/resources/migrations/sqlite/20251018000000_add_dark_logo.up.sql` (+5 -0) 📝 `frontend/src/lib/components/form/url-file-input.svelte` (+6 -4) 📝 `frontend/src/lib/services/oidc-service.ts` (+15 -9) 📝 `frontend/src/lib/types/oidc.type.ts` (+5 -1) 📝 `frontend/src/lib/utils/cached-image-util.ts` (+45 -33) 📝 `frontend/src/routes/settings/admin/application-configuration/application-image.svelte` (+2 -2) 📝 `frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte` (+14 -2) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte` (+93 -24) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-client-image-input.svelte` (+24 -11) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-client-list.svelte` (+4 -1) 📝 `frontend/src/routes/settings/apps/authorized-oidc-client-card.svelte` (+1 -1) 📝 `tests/specs/oidc-client-settings.spec.ts` (+10 -4) </details> ### 📄 Description Closes: https://github.com/pocket-id/pocket-id/issues/744 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-04 21:11:56 +03:00

OVERLORD closed this issue

2026-02-04 21:11:57 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id#1031