From df5c1ed1f80f00bf8435486f84f9c5569b0bdfd1 Mon Sep 17 00:00:00 2001
From: "Alessandro (Ale) Segala" <43508+ItalyPaleAle@users.noreply.github.com>
Date: Mon, 9 Jun 2025 12:15:37 -0700
Subject: [PATCH] chore: add docs link and rename to Federated Client
 Credentials (#636)

Co-authored-by: Elias Schneider <login@eliasschneider.com>
---
 frontend/messages/cs.json                      |  8 ++++----
 frontend/messages/da.json                      |  8 ++++----
 frontend/messages/de.json                      |  8 ++++----
 frontend/messages/en.json                      |  9 +++++----
 frontend/messages/es.json                      |  8 ++++----
 frontend/messages/fr.json                      |  8 ++++----
 frontend/messages/it.json                      |  8 ++++----
 frontend/messages/nl.json                      |  8 ++++----
 frontend/messages/pl.json                      |  8 ++++----
 frontend/messages/pt-BR.json                   |  8 ++++----
 frontend/messages/ru.json                      |  8 ++++----
 frontend/messages/zh-CN.json                   |  8 ++++----
 frontend/messages/zh-TW.json                   |  8 ++++----
 .../src/lib/components/form/form-input.svelte  | 18 +++++++++++++++++-
 .../federated-identities-input.svelte          | 12 ++++++++----
 15 files changed, 78 insertions(+), 57 deletions(-)

diff --git a/frontend/messages/cs.json b/frontend/messages/cs.json
index 5b9a4c8f..2d6f7436 100644
--- a/frontend/messages/cs.json
+++ b/frontend/messages/cs.json
@@ -346,10 +346,10 @@
 	"the_device_has_been_authorized": "Zařízení bylo autorizováno.",
 	"enter_code_displayed_in_previous_step": "Zadejte kód, který byl zobrazen v předchozím kroku.",
 	"authorize": "Autorizovat",
-	"federated_identities": "Federated Identities",
-	"federated_identities_description": "Using federated identities, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
-	"add_federated_identity": "Add Federated Identity",
-	"add_another_federated_identity": "Add another federated identity",
+	"federated_client_credentials": "Federated Client Credentials",
+	"federated_client_credentials_description": "Using federated client credentials, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
+	"add_federated_client_credential": "Add Federated Client Credential",
+	"add_another_federated_client_credential": "Add another federated client credential",
 	"oidc_allowed_group_count": "Počet povolených skupin",
 	"unrestricted": "Bez omezení",
 	"show_advanced_options": "Show Advanced Options",
diff --git a/frontend/messages/da.json b/frontend/messages/da.json
index 3562a233..abba7e3c 100644
--- a/frontend/messages/da.json
+++ b/frontend/messages/da.json
@@ -346,10 +346,10 @@
 	"the_device_has_been_authorized": "The device has been authorized.",
 	"enter_code_displayed_in_previous_step": "Enter the code that was displayed in the previous step.",
 	"authorize": "Authorize",
-	"federated_identities": "Federated Identities",
-	"federated_identities_description": "Using federated identities, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
-	"add_federated_identity": "Add Federated Identity",
-	"add_another_federated_identity": "Add another federated identity",
+	"federated_client_credentials": "Federated Client Credentials",
+	"federated_client_credentials_description": "Using federated client credentials, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
+	"add_federated_client_credential": "Add Federated Client Credential",
+	"add_another_federated_client_credential": "Add another federated client credential",
 	"oidc_allowed_group_count": "Allowed Group Count",
 	"unrestricted": "Unrestricted",
 	"show_advanced_options": "Show Advanced Options",
diff --git a/frontend/messages/de.json b/frontend/messages/de.json
index 0763d13e..29699f8d 100644
--- a/frontend/messages/de.json
+++ b/frontend/messages/de.json
@@ -346,10 +346,10 @@
 	"the_device_has_been_authorized": "Das Gerät wurde autorisiert.",
 	"enter_code_displayed_in_previous_step": "Gib den Code ein, der im vorherigen Schritt angezeigt wurde.",
 	"authorize": "Autorisieren",
-	"federated_identities": "Federated Identities",
-	"federated_identities_description": "Using federated identities, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
-	"add_federated_identity": "Add Federated Identity",
-	"add_another_federated_identity": "Add another federated identity",
+	"federated_client_credentials": "Federated Client Credentials",
+	"federated_client_credentials_description": "Using federated client credentials, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
+	"add_federated_client_credential": "Add Federated Client Credential",
+	"add_another_federated_client_credential": "Add another federated client credential",
 	"oidc_allowed_group_count": "Erlaubte Gruppenanzahl",
 	"unrestricted": "Uneingeschränkt",
 	"show_advanced_options": "Show Advanced Options",
diff --git a/frontend/messages/en.json b/frontend/messages/en.json
index 2328e04f..7e9c5771 100644
--- a/frontend/messages/en.json
+++ b/frontend/messages/en.json
@@ -3,6 +3,7 @@
 	"my_account": "My Account",
 	"logout": "Logout",
 	"confirm": "Confirm",
+	"docs": "Docs",
 	"key": "Key",
 	"value": "Value",
 	"remove_custom_claim": "Remove custom claim",
@@ -346,10 +347,10 @@
 	"the_device_has_been_authorized": "The device has been authorized.",
 	"enter_code_displayed_in_previous_step": "Enter the code that was displayed in the previous step.",
 	"authorize": "Authorize",
-	"federated_identities": "Federated Identities",
-	"federated_identities_description": "Using federated identities, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
-	"add_federated_identity": "Add Federated Identity",
-	"add_another_federated_identity": "Add another federated identity",
+	"federated_client_credentials": "Federated Client Credentials",
+	"federated_client_credentials_description": "Using federated client credentials, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
+	"add_federated_client_credential": "Add Federated Client Credential",
+	"add_another_federated_client_credential": "Add another federated client credential",
 	"oidc_allowed_group_count": "Allowed Group Count",
 	"unrestricted": "Unrestricted",
 	"show_advanced_options": "Show Advanced Options",
diff --git a/frontend/messages/es.json b/frontend/messages/es.json
index aa3ab0f9..a86f2493 100644
--- a/frontend/messages/es.json
+++ b/frontend/messages/es.json
@@ -346,10 +346,10 @@
 	"the_device_has_been_authorized": "The device has been authorized.",
 	"enter_code_displayed_in_previous_step": "Enter the code that was displayed in the previous step.",
 	"authorize": "Authorize",
-	"federated_identities": "Federated Identities",
-	"federated_identities_description": "Using federated identities, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
-	"add_federated_identity": "Add Federated Identity",
-	"add_another_federated_identity": "Add another federated identity",
+	"federated_client_credentials": "Federated Client Credentials",
+	"federated_client_credentials_description": "Using federated client credentials, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
+	"add_federated_client_credential": "Add Federated Client Credential",
+	"add_another_federated_client_credential": "Add another federated client credential",
 	"oidc_allowed_group_count": "Allowed Group Count",
 	"unrestricted": "Unrestricted",
 	"show_advanced_options": "Show Advanced Options",
diff --git a/frontend/messages/fr.json b/frontend/messages/fr.json
index 5049c052..e4d729fc 100644
--- a/frontend/messages/fr.json
+++ b/frontend/messages/fr.json
@@ -346,10 +346,10 @@
 	"the_device_has_been_authorized": "The device has been authorized.",
 	"enter_code_displayed_in_previous_step": "Enter the code that was displayed in the previous step.",
 	"authorize": "Authorize",
-	"federated_identities": "Federated Identities",
-	"federated_identities_description": "Using federated identities, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
-	"add_federated_identity": "Add Federated Identity",
-	"add_another_federated_identity": "Add another federated identity",
+	"federated_client_credentials": "Federated Client Credentials",
+	"federated_client_credentials_description": "Using federated client credentials, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
+	"add_federated_client_credential": "Add Federated Client Credential",
+	"add_another_federated_client_credential": "Add another federated client credential",
 	"oidc_allowed_group_count": "Allowed Group Count",
 	"unrestricted": "Unrestricted",
 	"show_advanced_options": "Show Advanced Options",
diff --git a/frontend/messages/it.json b/frontend/messages/it.json
index 8969feaa..d4222b97 100644
--- a/frontend/messages/it.json
+++ b/frontend/messages/it.json
@@ -346,10 +346,10 @@
 	"the_device_has_been_authorized": "Il dispositivo è stato autorizzato.",
 	"enter_code_displayed_in_previous_step": "Inserisci il codice visualizzato nel passaggio precedente.",
 	"authorize": "Autorizza",
-	"federated_identities": "Identità Federate",
-	"federated_identities_description": "Utilizzando identità federate, è possibile autenticare i client OIDC utilizzando i token JWT emessi da autorità di terze parti.",
-	"add_federated_identity": "Aggiungi Identità Federata",
-	"add_another_federated_identity": "Aggiungi un'altra identità federata",
+	"federated_client_credentials": "Identità Federate",
+	"federated_client_credentials_description": "Utilizzando identità federate, è possibile autenticare i client OIDC utilizzando i token JWT emessi da autorità di terze parti.",
+	"add_federated_client_credential": "Aggiungi Identità Federata",
+	"add_another_federated_client_credential": "Aggiungi un'altra identità federata",
 	"oidc_allowed_group_count": "Numero Gruppi Consentiti",
 	"unrestricted": "Illimitati",
 	"show_advanced_options": "Mostra Opzioni Avanzate",
diff --git a/frontend/messages/nl.json b/frontend/messages/nl.json
index 94ebec33..060487fe 100644
--- a/frontend/messages/nl.json
+++ b/frontend/messages/nl.json
@@ -346,10 +346,10 @@
 	"the_device_has_been_authorized": "The device has been authorized.",
 	"enter_code_displayed_in_previous_step": "Enter the code that was displayed in the previous step.",
 	"authorize": "Authorize",
-	"federated_identities": "Federated Identities",
-	"federated_identities_description": "Using federated identities, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
-	"add_federated_identity": "Add Federated Identity",
-	"add_another_federated_identity": "Add another federated identity",
+	"federated_client_credentials": "Federated Client Credentials",
+	"federated_client_credentials_description": "Using federated client credentials, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
+	"add_federated_client_credential": "Add Federated Client Credential",
+	"add_another_federated_client_credential": "Add another federated client credential",
 	"oidc_allowed_group_count": "Allowed Group Count",
 	"unrestricted": "Unrestricted",
 	"show_advanced_options": "Show Advanced Options",
diff --git a/frontend/messages/pl.json b/frontend/messages/pl.json
index 15ea8952..0cca5409 100644
--- a/frontend/messages/pl.json
+++ b/frontend/messages/pl.json
@@ -346,10 +346,10 @@
 	"the_device_has_been_authorized": "Urządzenie zostało autoryzowane.",
 	"enter_code_displayed_in_previous_step": "Wprowadź kod wyświetlony w poprzednim kroku.",
 	"authorize": "Autoryzuj",
-	"federated_identities": "Federated Identities",
-	"federated_identities_description": "Using federated identities, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
-	"add_federated_identity": "Add Federated Identity",
-	"add_another_federated_identity": "Add another federated identity",
+	"federated_client_credentials": "Federated Client Credentials",
+	"federated_client_credentials_description": "Using federated client credentials, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
+	"add_federated_client_credential": "Add Federated Client Credential",
+	"add_another_federated_client_credential": "Add another federated client credential",
 	"oidc_allowed_group_count": "Allowed Group Count",
 	"unrestricted": "Unrestricted",
 	"show_advanced_options": "Show Advanced Options",
diff --git a/frontend/messages/pt-BR.json b/frontend/messages/pt-BR.json
index 4e23aeaf..c735c783 100644
--- a/frontend/messages/pt-BR.json
+++ b/frontend/messages/pt-BR.json
@@ -346,10 +346,10 @@
 	"the_device_has_been_authorized": "The device has been authorized.",
 	"enter_code_displayed_in_previous_step": "Enter the code that was displayed in the previous step.",
 	"authorize": "Authorize",
-	"federated_identities": "Federated Identities",
-	"federated_identities_description": "Using federated identities, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
-	"add_federated_identity": "Add Federated Identity",
-	"add_another_federated_identity": "Add another federated identity",
+	"federated_client_credentials": "Federated Client Credentials",
+	"federated_client_credentials_description": "Using federated client credentials, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
+	"add_federated_client_credential": "Add Federated Client Credential",
+	"add_another_federated_client_credential": "Add another federated client credential",
 	"oidc_allowed_group_count": "Allowed Group Count",
 	"unrestricted": "Unrestricted",
 	"show_advanced_options": "Show Advanced Options",
diff --git a/frontend/messages/ru.json b/frontend/messages/ru.json
index 474f7765..cc219946 100644
--- a/frontend/messages/ru.json
+++ b/frontend/messages/ru.json
@@ -346,10 +346,10 @@
 	"the_device_has_been_authorized": "Устройство авторизовано.",
 	"enter_code_displayed_in_previous_step": "Введите код, который был отображен на предыдущем шаге.",
 	"authorize": "Авторизируйте",
-	"federated_identities": "Federated Identities",
-	"federated_identities_description": "Using federated identities, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
-	"add_federated_identity": "Add Federated Identity",
-	"add_another_federated_identity": "Add another federated identity",
+	"federated_client_credentials": "Federated Client Credentials",
+	"federated_client_credentials_description": "Using federated client credentials, you can authenticate OIDC clients using JWT tokens issued by third-party authorities.",
+	"add_federated_client_credential": "Add Federated Client Credential",
+	"add_another_federated_client_credential": "Add another federated client credential",
 	"oidc_allowed_group_count": "Кол-во разрешенных групп",
 	"unrestricted": "Не ограничено",
 	"show_advanced_options": "Show Advanced Options",
diff --git a/frontend/messages/zh-CN.json b/frontend/messages/zh-CN.json
index 5706472e..af9053da 100644
--- a/frontend/messages/zh-CN.json
+++ b/frontend/messages/zh-CN.json
@@ -346,10 +346,10 @@
 	"the_device_has_been_authorized": "设备已授权",
 	"enter_code_displayed_in_previous_step": "输入在上一步中显示的代码",
 	"authorize": "授权",
-	"federated_identities": "联合身份",
-	"federated_identities_description": "您可以使用联合身份，通过第三方授权机构签发的 JWT 令牌，对 OIDC 客户端进行认证。",
-	"add_federated_identity": "添加联合身份",
-	"add_another_federated_identity": "添加另一个联合身份",
+	"federated_client_credentials": "联合身份",
+	"federated_client_credentials_description": "您可以使用联合身份，通过第三方授权机构签发的 JWT 令牌，对 OIDC 客户端进行认证。",
+	"add_federated_client_credential": "添加联合身份",
+	"add_another_federated_client_credential": "添加另一个联合身份",
 	"oidc_allowed_group_count": "允许的群组数量",
 	"unrestricted": "不受限制",
 	"show_advanced_options": "显示高级选项",
diff --git a/frontend/messages/zh-TW.json b/frontend/messages/zh-TW.json
index 0ab8c5e3..316b7bc9 100644
--- a/frontend/messages/zh-TW.json
+++ b/frontend/messages/zh-TW.json
@@ -346,10 +346,10 @@
 	"the_device_has_been_authorized": "裝置已獲授權。",
 	"enter_code_displayed_in_previous_step": "請輸入上一步顯示的代碼。",
 	"authorize": "授權",
-	"federated_identities": "聯邦身分",
-	"federated_identities_description": "使用聯邦身分，您可以透過由第三方授權機構簽發的 JWT 權杖來驗證 OIDC 客戶端。",
-	"add_federated_identity": "增加聯邦身分",
-	"add_another_federated_identity": "新增另一組聯邦身分",
+	"federated_client_credentials": "聯邦身分",
+	"federated_client_credentials_description": "使用聯邦身分，您可以透過由第三方授權機構簽發的 JWT 權杖來驗證 OIDC 客戶端。",
+	"add_federated_client_credential": "增加聯邦身分",
+	"add_another_federated_client_credential": "新增另一組聯邦身分",
 	"oidc_allowed_group_count": "允許的群組數量",
 	"unrestricted": "未受限制",
 	"show_advanced_options": "顯示進階選項",
diff --git a/frontend/src/lib/components/form/form-input.svelte b/frontend/src/lib/components/form/form-input.svelte
index d84e4493..20c7878e 100644
--- a/frontend/src/lib/components/form/form-input.svelte
+++ b/frontend/src/lib/components/form/form-input.svelte
@@ -2,7 +2,9 @@
 	import DatePicker from '$lib/components/form/date-picker.svelte';
 	import { Input, type FormInputEvent } from '$lib/components/ui/input';
 	import { Label } from '$lib/components/ui/label';
+	import { m } from '$lib/paraglide/messages';
 	import type { FormInput } from '$lib/utils/form-util';
+	import { LucideExternalLink } from '@lucide/svelte';
 	import type { Snippet } from 'svelte';
 	import type { HTMLAttributes } from 'svelte/elements';
 
@@ -10,6 +12,7 @@
 		input = $bindable(),
 		label,
 		description,
+		docsLink,
 		placeholder,
 		disabled = false,
 		type = 'text',
@@ -20,6 +23,7 @@
 		input?: FormInput<string | boolean | number | Date | undefined>;
 		label?: string;
 		description?: string;
+		docsLink?: string;
 		placeholder?: string;
 		disabled?: boolean;
 		type?: 'text' | 'password' | 'email' | 'number' | 'checkbox' | 'date';
@@ -35,7 +39,19 @@
 		<Label class="mb-0" for={id}>{label}</Label>
 	{/if}
 	{#if description}
-		<p class="text-muted-foreground mt-1 text-xs">{description}</p>
+		<p class="text-muted-foreground mt-1 text-xs">
+			{description}
+			{#if docsLink}
+				<a
+					class="relative text-white after:absolute after:bottom-0 after:left-0 after:h-px after:w-full after:translate-y-[-1px] after:bg-white"
+					href={docsLink}
+					target="_blank"
+				>
+					{m.docs()}
+					<LucideExternalLink class="inline size-3 align-text-top" />
+				</a>
+			{/if}
+		</p>
 	{/if}
 	<div class={label || description ? 'mt-2' : ''}>
 		{#if children}
diff --git a/frontend/src/routes/settings/admin/oidc-clients/federated-identities-input.svelte b/frontend/src/routes/settings/admin/oidc-clients/federated-identities-input.svelte
index 01f20cfe..564e3d34 100644
--- a/frontend/src/routes/settings/admin/oidc-clients/federated-identities-input.svelte
+++ b/frontend/src/routes/settings/admin/oidc-clients/federated-identities-input.svelte
@@ -51,7 +51,7 @@
 	}
 
 	function getFieldError(index: number, field: keyof OidcClientFederatedIdentity): string | null {
-		console.log(federatedIdentities)
+		console.log(federatedIdentities);
 		if (!errors) return null;
 		const path = [index, field];
 		return errors?.filter((e) => e.path[0] == path[0] && e.path[1] == path[1])[0]?.message;
@@ -59,7 +59,11 @@
 </script>
 
 <div {...restProps}>
-	<FormInput label={m.federated_identities()} description={m.federated_identities_description()}>
+	<FormInput
+		label={m.federated_client_credentials()}
+		description={m.federated_client_credentials_description()}
+		docsLink="https://pocket-id.org/docs/guides/oidc-client-authentication"
+	>
 		<div class="space-y-4">
 			{#each federatedIdentities as identity, i}
 				<div class="space-y-3 rounded-lg border p-4">
@@ -142,7 +146,7 @@
 	<Button class="mt-3" variant="secondary" size="sm" onclick={addFederatedIdentity} type="button">
 		<LucidePlus class="mr-1 size-4" />
 		{federatedIdentities.length === 0
-			? m.add_federated_identity()
-			: m.add_another_federated_identity()}
+			? m.add_federated_client_credential()
+			: m.add_another_federated_client_credential()}
 	</Button>
 </div>