starred/pocket-id-pocket-id-2
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 05:02:58 +03:00
Code Issues 116 Packages Projects Releases 10 Wiki Activity

[PR #202] [MERGED] feat: map allowed groups to OIDC clients #920

New Issue
Open
opened 2025-10-09 16:59:47 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-09 16:59:47 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/202
Author: @stonith404
Created: 2/3/2025
Status: ✅ Merged
Merged: 2/3/2025
Merged by: @stonith404

Base: main ← Head: feat/disallow-clients

📝 Commits (2)

  • 033ef06 add ability to disallow clients for users
  • 4472705 adapt tests

📊 Changes

30 files changed (+514 additions, -214 deletions)

View changed files

📝 backend/internal/common/errors.go (+8 -0)
📝 backend/internal/controller/oidc_controller.go (+32 -13)
📝 backend/internal/dto/oidc_dto.go (+17 -1)
📝 backend/internal/dto/user_group_dto.go (+0 -4)
📝 backend/internal/model/oidc.go (+3 -2)
📝 backend/internal/service/oidc_service.go (+102 -35)
📝 backend/internal/service/test_service.go (+15 -8)
➕ backend/resources/migrations/postgres/20250131154719_oidc_user_group_restriction.down.sql (+1 -0)
➕ backend/resources/migrations/postgres/20250131154719_oidc_user_group_restriction.up.sql (+8 -0)
➕ backend/resources/migrations/sqlite/20250131154719_oidc_user_group_restriction.down.sql (+1 -0)
➕ backend/resources/migrations/sqlite/20250131154719_oidc_user_group_restriction.up.sql (+8 -0)
➕ frontend/src/lib/components/collapsible-card.svelte (+75 -0)
📝 frontend/src/lib/components/ui/card/card-description.svelte (+1 -1)
📝 frontend/src/lib/services/oidc-service.ts (+16 -17)
📝 frontend/src/lib/types/oidc.type.ts (+6 -0)
📝 frontend/src/routes/authorize/+page.svelte (+19 -35)
📝 frontend/src/routes/authorize/components/client-provider-images.svelte (+5 -3)
📝 frontend/src/routes/settings/admin/application-configuration/+page.svelte (+22 -40)
📝 frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte (+36 -6)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte (+1 -1)

...and 10 more files

📄 Description

Fixes #98

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/202 **Author:** [@stonith404](https://github.com/stonith404) **Created:** 2/3/2025 **Status:** ✅ Merged **Merged:** 2/3/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `feat/disallow-clients` --- ### 📝 Commits (2) - [`033ef06`](https://github.com/pocket-id/pocket-id/commit/033ef06545a6a7f2f13601e0b18ec9945007f10b) add ability to disallow clients for users - [`4472705`](https://github.com/pocket-id/pocket-id/commit/4472705603227f0ebb5d73015361d1c15e8b18f9) adapt tests ### 📊 Changes **30 files changed** (+514 additions, -214 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/common/errors.go` (+8 -0) 📝 `backend/internal/controller/oidc_controller.go` (+32 -13) 📝 `backend/internal/dto/oidc_dto.go` (+17 -1) 📝 `backend/internal/dto/user_group_dto.go` (+0 -4) 📝 `backend/internal/model/oidc.go` (+3 -2) 📝 `backend/internal/service/oidc_service.go` (+102 -35) 📝 `backend/internal/service/test_service.go` (+15 -8) ➕ `backend/resources/migrations/postgres/20250131154719_oidc_user_group_restriction.down.sql` (+1 -0) ➕ `backend/resources/migrations/postgres/20250131154719_oidc_user_group_restriction.up.sql` (+8 -0) ➕ `backend/resources/migrations/sqlite/20250131154719_oidc_user_group_restriction.down.sql` (+1 -0) ➕ `backend/resources/migrations/sqlite/20250131154719_oidc_user_group_restriction.up.sql` (+8 -0) ➕ `frontend/src/lib/components/collapsible-card.svelte` (+75 -0) 📝 `frontend/src/lib/components/ui/card/card-description.svelte` (+1 -1) 📝 `frontend/src/lib/services/oidc-service.ts` (+16 -17) 📝 `frontend/src/lib/types/oidc.type.ts` (+6 -0) 📝 `frontend/src/routes/authorize/+page.svelte` (+19 -35) 📝 `frontend/src/routes/authorize/components/client-provider-images.svelte` (+5 -3) 📝 `frontend/src/routes/settings/admin/application-configuration/+page.svelte` (+22 -40) 📝 `frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte` (+36 -6) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte` (+1 -1) _...and 10 more files_ </details> ### 📄 Description Fixes #98 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 16:59:47 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-2#920
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?