starred/pocket-id-pocket-id-2
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 05:02:58 +03:00
Code Issues 116 Packages Projects Releases 10 Wiki Activity

[PR #216] [MERGED] feat: ldap search filters #913

New Issue
Open
opened 2025-10-09 16:59:38 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-09 16:59:38 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/216
Author: @kmendell
Created: 2/7/2025
Status: ✅ Merged
Merged: 2/8/2025
Merged by: @stonith404

Base: main ← Head: ldap-filters

📝 Commits (10+)

  • 7f95434 add ldap search filters
  • e73529f add search filters to updatedAppConfig
  • b65f738 add new inputs to e2e tests
  • 8a4f624 fix placeholder values
  • 97b9d8c fix appconfig to the correct frontend values
  • a280f5d add ldap filter options to app config dto
  • 11fb856 cleanup unused code
  • fb37560 add default values for ldap filters
  • c2c55c2 change group filter
  • ea06aa2 add missing filter values to application-configuration.ts for frontend store

📊 Changes

7 files changed (+38 additions, -3 deletions)

View changed files

📝 backend/internal/dto/app_config_dto.go (+2 -0)
📝 backend/internal/model/app_config.go (+2 -0)
📝 backend/internal/service/app_config_service.go (+10 -0)
📝 backend/internal/service/ldap_service.go (+2 -3)
📝 frontend/src/lib/types/application-configuration.ts (+2 -0)
📝 frontend/src/routes/settings/admin/application-configuration/forms/app-config-ldap-form.svelte (+16 -0)
📝 frontend/tests/application-configuration.spec.ts (+4 -0)

📄 Description

This will fix https://github.com/pocket-id/pocket-id/issues/215

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/216 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 2/7/2025 **Status:** ✅ Merged **Merged:** 2/8/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `ldap-filters` --- ### 📝 Commits (10+) - [`7f95434`](https://github.com/pocket-id/pocket-id/commit/7f95434c765bb944104990be8f7fd5ac5e139263) add ldap search filters - [`e73529f`](https://github.com/pocket-id/pocket-id/commit/e73529f9176a3243fc00d1f521a30a53429211cf) add search filters to updatedAppConfig - [`b65f738`](https://github.com/pocket-id/pocket-id/commit/b65f738e5085c13869e330ecfefa281767f2b1e9) add new inputs to e2e tests - [`8a4f624`](https://github.com/pocket-id/pocket-id/commit/8a4f6241db26ced9670e9514f14ab14d40923fab) fix placeholder values - [`97b9d8c`](https://github.com/pocket-id/pocket-id/commit/97b9d8c06f649a05d47ede4d0a02b6ed1aba5471) fix appconfig to the correct frontend values - [`a280f5d`](https://github.com/pocket-id/pocket-id/commit/a280f5dd37aef08a5ecc00f1439e286a6fefa6bb) add ldap filter options to app config dto - [`11fb856`](https://github.com/pocket-id/pocket-id/commit/11fb856e7bcb6defe3606c03ee40b5f419af8ec0) cleanup unused code - [`fb37560`](https://github.com/pocket-id/pocket-id/commit/fb37560662532e110559493616ef9e1a5db3e561) add default values for ldap filters - [`c2c55c2`](https://github.com/pocket-id/pocket-id/commit/c2c55c24b4373dd22f189a4a8ed41ce0f3cbd8de) change group filter - [`ea06aa2`](https://github.com/pocket-id/pocket-id/commit/ea06aa29f224244f040586b09a79785e19044410) add missing filter values to application-configuration.ts for frontend store ### 📊 Changes **7 files changed** (+38 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/dto/app_config_dto.go` (+2 -0) 📝 `backend/internal/model/app_config.go` (+2 -0) 📝 `backend/internal/service/app_config_service.go` (+10 -0) 📝 `backend/internal/service/ldap_service.go` (+2 -3) 📝 `frontend/src/lib/types/application-configuration.ts` (+2 -0) 📝 `frontend/src/routes/settings/admin/application-configuration/forms/app-config-ldap-form.svelte` (+16 -0) 📝 `frontend/tests/application-configuration.spec.ts` (+4 -0) </details> ### 📄 Description This will fix https://github.com/pocket-id/pocket-id/issues/215 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 16:59:38 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-2#913
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?