starred/pocket-id-pocket-id-2
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:42:59 +03:00
Code Issues 116 Packages Projects Releases 10 Wiki Activity

[PR #220] [MERGED] feat: add warning for only having one passkey configured #907

New Issue
Closed
opened 2025-10-09 16:59:31 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-09 16:59:31 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/220
Author: @kmendell
Created: 2/8/2025
Status: ✅ Merged
Merged: 2/12/2025
Merged by: @stonith404

Base: main ← Head: passkey-warning

📝 Commits (7)

  • 0ea9191 add warning for only having one passkey configured
  • 6748521 fix typo
  • af5e8ef add 'x' button to alert
  • bed3a50 remove triangle warning and replace with 'x' button
  • 1aa7b92 add local storage logic for passkey warning
  • 6de2140 Merge branch 'pocket-id:main' into passkey-warning
  • 08879f0 move dismiss logic inside alert component

📊 Changes

2 files changed (+42 additions, -5 deletions)

View changed files

📝 frontend/src/lib/components/ui/alert/alert.svelte (+30 -4)
📝 frontend/src/routes/settings/account/+page.svelte (+12 -1)

📄 Description

This will fix: https://github.com/pocket-id/pocket-id/issues/217

TODO

  • Add Dismiss option to alert

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/220 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 2/8/2025 **Status:** ✅ Merged **Merged:** 2/12/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `passkey-warning` --- ### 📝 Commits (7) - [`0ea9191`](https://github.com/pocket-id/pocket-id/commit/0ea9191f2873a301b8cd6de9236cbc69a4859ec4) add warning for only having one passkey configured - [`6748521`](https://github.com/pocket-id/pocket-id/commit/67485214832309292f0eb1c3c0a1bf6f48d9c737) fix typo - [`af5e8ef`](https://github.com/pocket-id/pocket-id/commit/af5e8ef6e032f3f2841f0ca737f326ca243afea5) add 'x' button to alert - [`bed3a50`](https://github.com/pocket-id/pocket-id/commit/bed3a50c241ea5df9521c18f38ce13732286ac1f) remove triangle warning and replace with 'x' button - [`1aa7b92`](https://github.com/pocket-id/pocket-id/commit/1aa7b92be255999977443f431ca5daea86ba7c43) add local storage logic for passkey warning - [`6de2140`](https://github.com/pocket-id/pocket-id/commit/6de214022fd0d9eff02e3c1a93078e434cf55aa8) Merge branch 'pocket-id:main' into passkey-warning - [`08879f0`](https://github.com/pocket-id/pocket-id/commit/08879f00ba945e0bf903fd3e95664aaab64cc279) move dismiss logic inside alert component ### 📊 Changes **2 files changed** (+42 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/lib/components/ui/alert/alert.svelte` (+30 -4) 📝 `frontend/src/routes/settings/account/+page.svelte` (+12 -1) </details> ### 📄 Description This will fix: https://github.com/pocket-id/pocket-id/issues/217 ## TODO - [ ] Add Dismiss option to alert --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 16:59:31 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-2#907
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?