starred/pocket-id-pocket-id-2
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-06 05:02:58 +03:00
Code Issues 116 Packages Projects Releases 10 Wiki Activity

[PR #226] [MERGED] Add GEOLITE_DB_URL and handle an empty MAXMIND_LICENSE_KEY #905

New Issue
Open
opened 2025-10-09 16:59:28 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-09 16:59:28 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/226
Author: @wargio
Created: 2/11/2025
Status: ✅ Merged
Merged: 2/13/2025
Merged by: @stonith404

Base: main ← Head: custom-geolite-db-url

📝 Commits (2)

  • 1793a03 Add GEOLITE_DB_URL
  • 10f968c Merge branch 'main' into custom-geolite-db-url

📊 Changes

4 files changed (+21 additions, -10 deletions)

View changed files

📝 backend/internal/common/env_config.go (+5 -2)
📝 backend/internal/service/geolite_service.go (+14 -6)
📝 backend/internal/service/test_service.go (+1 -1)
📝 backend/internal/service/user_service.go (+1 -1)

📄 Description

Adds GEOLITE_DB_URL and handles the edge case where MAXMIND_LICENSE_KEY is not defined, avoiding to make a useless http request to the service.

Fix https://github.com/pocket-id/pocket-id/issues/111

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/226 **Author:** [@wargio](https://github.com/wargio) **Created:** 2/11/2025 **Status:** ✅ Merged **Merged:** 2/13/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `custom-geolite-db-url` --- ### 📝 Commits (2) - [`1793a03`](https://github.com/pocket-id/pocket-id/commit/1793a03a4a09feb350b64689b9bbba1873147d0c) Add GEOLITE_DB_URL - [`10f968c`](https://github.com/pocket-id/pocket-id/commit/10f968c759a21b4b0dc56920f95fa48215207bef) Merge branch 'main' into custom-geolite-db-url ### 📊 Changes **4 files changed** (+21 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/common/env_config.go` (+5 -2) 📝 `backend/internal/service/geolite_service.go` (+14 -6) 📝 `backend/internal/service/test_service.go` (+1 -1) 📝 `backend/internal/service/user_service.go` (+1 -1) </details> ### 📄 Description Adds `GEOLITE_DB_URL` and handles the edge case where `MAXMIND_LICENSE_KEY` is not defined, avoiding to make a useless http request to the service. Fix https://github.com/pocket-id/pocket-id/issues/111 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 16:59:28 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-2#905
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?