starred/pocket-id-pocket-id-2
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:42:59 +03:00
Code Issues 116 Packages Projects Releases 10 Wiki Activity

[PR #492] [MERGED] fix: last name still showing as required on account form #771

New Issue
Closed
opened 2025-10-09 16:56:53 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-09 16:56:53 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/492
Author: @kmendell
Created: 4/29/2025
Status: ✅ Merged
Merged: 4/29/2025
Merged by: @stonith404

Base: main ← Head: fix/last-name-form

📝 Commits (2)

  • 5f64a05 fix: last name still showing as required on account form
  • 9df8e8f remove unused import

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 frontend/src/routes/settings/account/account-form.svelte (+1 -2)

📄 Description

Fixes: https://github.com/pocket-id/pocket-id/issues/439

Missed a little part from the last PR. This small change should fix it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/492 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 4/29/2025 **Status:** ✅ Merged **Merged:** 4/29/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `fix/last-name-form` --- ### 📝 Commits (2) - [`5f64a05`](https://github.com/pocket-id/pocket-id/commit/5f64a05d67602c9bd1d86ce101e8d0b8d5f07603) fix: last name still showing as required on account form - [`9df8e8f`](https://github.com/pocket-id/pocket-id/commit/9df8e8ffacc7f7636277f5860e3ed544db5d9be1) remove unused import ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/routes/settings/account/account-form.svelte` (+1 -2) </details> ### 📄 Description Fixes: https://github.com/pocket-id/pocket-id/issues/439 Missed a little part from the last PR. This small change should fix it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 16:56:53 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-2#771
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?