starred/pocket-id-pocket-id-2
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-11 07:32:57 +03:00
Code Issues 116 Packages Projects Releases 10 Wiki Activity

[PR #532] [MERGED] fix: flaky unit test in db_bootstrap_test #756

New Issue
Closed
opened 2025-10-09 16:56:36 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-09 16:56:36 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/532
Author: @ItalyPaleAle
Created: 5/14/2025
Status: ✅ Merged
Merged: 5/14/2025
Merged by: @kmendell

Base: main ← Head: fix-flaky-sqlite-unit-test

📝 Commits (2)

📊 Changes

1 file changed (+27 additions, -3 deletions)

View changed files

📝 backend/internal/bootstrap/db_bootstrap_test.go (+27 -3)

📄 Description

Go's url.Values can be serialized in random order, which the test case didn't account for

Fixup from #530

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/532 **Author:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Created:** 5/14/2025 **Status:** ✅ Merged **Merged:** 5/14/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `fix-flaky-sqlite-unit-test` --- ### 📝 Commits (2) - [`d44b6ca`](https://github.com/pocket-id/pocket-id/commit/d44b6cabf229245bd3ca9b96a207a5e94faf88d2) fix: flaky unit test in db_bootstrap_test - [`af0a90e`](https://github.com/pocket-id/pocket-id/commit/af0a90e9bf18149a772bd7697f93542d368fa16c) Lint ### 📊 Changes **1 file changed** (+27 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/bootstrap/db_bootstrap_test.go` (+27 -3) </details> ### 📄 Description Go's url.Values can be serialized in random order, which the test case didn't account for Fixup from #530 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 16:56:36 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-2#756
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?