starred/pocket-id-pocket-id-2
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:42:59 +03:00
Code Issues 116 Packages Projects Releases 10 Wiki Activity

[PR #588] [MERGED] fix: don't use TOFU for logout callback URLs #726

New Issue
Closed
opened 2025-10-09 16:55:59 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-09 16:55:59 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/588
Author: @ItalyPaleAle
Created: 5/29/2025
Status: ✅ Merged
Merged: 5/29/2025
Merged by: @stonith404

Base: main ← Head: fix-transaction-583

📝 Commits (5)

  • 24e2b69 fix: use transaction when updating callback URLs
  • 9b226c5 No TOFU for logout callback URL
  • 07972a9 fix wrong callback url list
  • 6b73e77 change description for logout callback URLs
  • 34b3829 remove unnecessary transation

📊 Changes

4 files changed (+49 additions, -24 deletions)

View changed files

📝 backend/internal/service/oidc_service.go (+43 -23)
📝 frontend/messages/en-US.json (+1 -0)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-callback-url-input.svelte (+3 -1)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte (+2 -0)

📄 Description

Fixup from #583

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/588 **Author:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Created:** 5/29/2025 **Status:** ✅ Merged **Merged:** 5/29/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `fix-transaction-583` --- ### 📝 Commits (5) - [`24e2b69`](https://github.com/pocket-id/pocket-id/commit/24e2b6983855c02387ee9d56845553e2debc4839) fix: use transaction when updating callback URLs - [`9b226c5`](https://github.com/pocket-id/pocket-id/commit/9b226c5715c7d927dde43507015957f4b72906c5) No TOFU for logout callback URL - [`07972a9`](https://github.com/pocket-id/pocket-id/commit/07972a99675a82dede05b56b26f21c8a6f39194c) fix wrong callback url list - [`6b73e77`](https://github.com/pocket-id/pocket-id/commit/6b73e7735f63c76b9810d43a79c51c771e692656) change description for logout callback URLs - [`34b3829`](https://github.com/pocket-id/pocket-id/commit/34b38298f7f3916535d6bb0ec1168a3b139bcc2b) remove unnecessary transation ### 📊 Changes **4 files changed** (+49 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/service/oidc_service.go` (+43 -23) 📝 `frontend/messages/en-US.json` (+1 -0) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-callback-url-input.svelte` (+3 -1) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte` (+2 -0) </details> ### 📄 Description Fixup from #583 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 16:55:59 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-2#726
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?