[PR #737] [MERGED] fix: login failures on Postgres when IP is null #648

New Issue

OVERLORD · 2025-10-09T16:54:26+03:00

OVERLORD commented

2025-10-09 16:54:26 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/737
Author: @ItalyPaleAle
Created: 7/9/2025
Status: ✅ Merged
Merged: 7/9/2025
Merged by: @kmendell

Base: main ← Head: fix-686-2

📝 Commits (1)

b04569d fix: login failures on Postgres when IP is null

📊 Changes

3 files changed (+11 additions, -8 deletions)

View changed files

📝 backend/internal/middleware/rate_limit.go (+1 -1)
📝 backend/internal/service/audit_log_service.go (+9 -4)
📝 backend/internal/service/user_service.go (+1 -3)

📄 Description

fixes #686 (for real)

The fix in #695 was not complete. It allowed the entry to be stored in the DB, but still caused failures when reading. This completes the fix.

Also fixes: authenticating with a one-time code did not create a log entry when the IP is empty

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/737 **Author:** [@ItalyPaleAle](https://github.com/ItalyPaleAle) **Created:** 7/9/2025 **Status:** ✅ Merged **Merged:** 7/9/2025 **Merged by:** [@kmendell](https://github.com/kmendell) **Base:** `main` ← **Head:** `fix-686-2` --- ### 📝 Commits (1) - [`b04569d`](https://github.com/pocket-id/pocket-id/commit/b04569dafd9eea5c61a1f81eaffb6b35afe910e8) fix: login failures on Postgres when IP is null ### 📊 Changes **3 files changed** (+11 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/middleware/rate_limit.go` (+1 -1) 📝 `backend/internal/service/audit_log_service.go` (+9 -4) 📝 `backend/internal/service/user_service.go` (+1 -3) </details> ### 📄 Description fixes #686 (for real) The fix in #695 was not complete. It allowed the entry to be stored in the DB, but still caused failures when reading. This completes the fix. Also fixes: authenticating with a one-time code did not create a log entry when the IP is empty --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 16:54:26 +03:00

OVERLORD closed this issue

2025-10-09 16:54:27 +03:00

OVERLORD referenced this issue

2025-10-09 16:55:23 +03:00

[PR #648] [MERGED] fix: reduce duration of animations on login and signin page #697

Sign in to join this conversation.