starred/pocket-id-pocket-id-2
1
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2025-12-09 14:42:59 +03:00
Code Issues 116 Packages Projects Releases 10 Wiki Activity

[PR #846] [MERGED] tests: use proper async calls for cleanupBackend function #594

New Issue
Closed
opened 2025-10-09 16:53:24 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2025-10-09 16:53:24 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/846
Author: @kmendell
Created: 8/18/2025
Status: ✅ Merged
Merged: 8/20/2025
Merged by: @stonith404

Base: main ← Head: tests/proper-async

📝 Commits (3)

  • d0568ae tests: use proper async calls for cleanupBackend function
  • ff6723b revert jwt util changes
  • e16f522 remove unused import

📊 Changes

10 files changed (+10 additions, -10 deletions)

View changed files

📝 tests/specs/account-settings.spec.ts (+1 -1)
📝 tests/specs/application-configuration.spec.ts (+1 -1)
📝 tests/specs/apps-dashboard.spec.ts (+1 -1)
📝 tests/specs/ldap.spec.ts (+1 -1)
📝 tests/specs/oidc-client-settings.spec.ts (+1 -1)
📝 tests/specs/oidc.spec.ts (+1 -1)
📝 tests/specs/one-time-access-token.spec.ts (+1 -1)
📝 tests/specs/user-group.spec.ts (+1 -1)
📝 tests/specs/user-settings.spec.ts (+1 -1)
📝 tests/specs/user-signup.spec.ts (+1 -1)

📄 Description

Also fixed the warning in the jwt.util about top level async.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/846 **Author:** [@kmendell](https://github.com/kmendell) **Created:** 8/18/2025 **Status:** ✅ Merged **Merged:** 8/20/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `tests/proper-async` --- ### 📝 Commits (3) - [`d0568ae`](https://github.com/pocket-id/pocket-id/commit/d0568aec3dba7e64ca1bbe29394e368cfbb4ead3) tests: use proper async calls for cleanupBackend function - [`ff6723b`](https://github.com/pocket-id/pocket-id/commit/ff6723b960e356355f031c17049b1f4f89af0551) revert jwt util changes - [`e16f522`](https://github.com/pocket-id/pocket-id/commit/e16f5225b482d1793713129e65f3d0860451a424) remove unused import ### 📊 Changes **10 files changed** (+10 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `tests/specs/account-settings.spec.ts` (+1 -1) 📝 `tests/specs/application-configuration.spec.ts` (+1 -1) 📝 `tests/specs/apps-dashboard.spec.ts` (+1 -1) 📝 `tests/specs/ldap.spec.ts` (+1 -1) 📝 `tests/specs/oidc-client-settings.spec.ts` (+1 -1) 📝 `tests/specs/oidc.spec.ts` (+1 -1) 📝 `tests/specs/one-time-access-token.spec.ts` (+1 -1) 📝 `tests/specs/user-group.spec.ts` (+1 -1) 📝 `tests/specs/user-settings.spec.ts` (+1 -1) 📝 `tests/specs/user-signup.spec.ts` (+1 -1) </details> ### 📄 Description Also fixed the warning in the jwt.util about top level async. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2025-10-09 16:53:24 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
breaking
bug
documentation
feature
needs more upvotes
open to pull requests
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-2#594
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?