[PR #864] [MERGED] feat: allow custom client IDs #586

New Issue

OVERLORD · 2025-10-09T16:53:13+03:00

OVERLORD commented

2025-10-09 16:53:13 +03:00

📋 Pull Request Information

Original PR: https://github.com/pocket-id/pocket-id/pull/864
Author: @stonith404
Created: 8/22/2025
Status: ✅ Merged
Merged: 8/23/2025
Merged by: @stonith404

Base: main ← Head: feat/customizable-client-id

📝 Commits (9)

2a545cc feat: allow custom client IDs
ac79baa improve error for existing client id
00b1cc1 fix unit tests
7ee4fd0 add missing error check
233204d add e2e test
8235ffd keep api key description optional
55e0e0c Merge branch 'main' into feat/customizable-client-id
5ace1e3 allow dots in client id
f1cb6c0 Merge branch 'main' into feat/customizable-client-id

📊 Changes

15 files changed (+151 additions, -56 deletions)

View changed files

📝 backend/internal/common/errors.go (+10 -0)
📝 backend/internal/controller/oidc_controller.go (+2 -2)
📝 backend/internal/dto/oidc_dto.go (+6 -1)
📝 backend/internal/dto/validations.go (+10 -0)
📝 backend/internal/service/oidc_service.go (+9 -3)
📝 backend/internal/service/oidc_service_test.go (+14 -8)
📝 frontend/messages/en.json (+4 -1)
📝 frontend/src/lib/services/oidc-service.ts (+2 -1)
📝 frontend/src/lib/types/oidc.type.ts (+7 -1)
📝 frontend/src/lib/utils/zod-util.ts (+2 -4)
📝 frontend/src/routes/settings/admin/api-keys/api-key-form.svelte (+2 -2)
📝 frontend/src/routes/settings/admin/oidc-clients/+page.svelte (+1 -1)
📝 frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte (+1 -1)
📝 frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte (+31 -5)
📝 tests/specs/oidc-client-settings.spec.ts (+50 -26)

📄 Description

Allows users to set a custom client ID for new clients. Fixes #508.

Thanks to @James18232 for the foundation of this PR in #830.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pocket-id/pocket-id/pull/864 **Author:** [@stonith404](https://github.com/stonith404) **Created:** 8/22/2025 **Status:** ✅ Merged **Merged:** 8/23/2025 **Merged by:** [@stonith404](https://github.com/stonith404) **Base:** `main` ← **Head:** `feat/customizable-client-id` --- ### 📝 Commits (9) - [`2a545cc`](https://github.com/pocket-id/pocket-id/commit/2a545cc5b14f2d64b36985c01fb901db4abe452c) feat: allow custom client IDs - [`ac79baa`](https://github.com/pocket-id/pocket-id/commit/ac79baa4aafa980eb940df171e1d12dc8eb5f639) improve error for existing client id - [`00b1cc1`](https://github.com/pocket-id/pocket-id/commit/00b1cc18e972523322738dda80171107dd45ea54) fix unit tests - [`7ee4fd0`](https://github.com/pocket-id/pocket-id/commit/7ee4fd0739235cc9311db0b27bc4fbce476ef74c) add missing error check - [`233204d`](https://github.com/pocket-id/pocket-id/commit/233204d8b180d072f78054ce45e56c0a9a5a08a6) add e2e test - [`8235ffd`](https://github.com/pocket-id/pocket-id/commit/8235ffdf42f2da6e8b1aefb81070bccec33adb28) keep api key description optional - [`55e0e0c`](https://github.com/pocket-id/pocket-id/commit/55e0e0c9d138c4fbb5b4c7ef9d8eefa1b318c26f) Merge branch 'main' into feat/customizable-client-id - [`5ace1e3`](https://github.com/pocket-id/pocket-id/commit/5ace1e3811ff59214e0dd920d151ad8bd156c6e6) allow dots in client id - [`f1cb6c0`](https://github.com/pocket-id/pocket-id/commit/f1cb6c0b1d2809f3ac1c5267c7554967f6bb739a) Merge branch 'main' into feat/customizable-client-id ### 📊 Changes **15 files changed** (+151 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/common/errors.go` (+10 -0) 📝 `backend/internal/controller/oidc_controller.go` (+2 -2) 📝 `backend/internal/dto/oidc_dto.go` (+6 -1) 📝 `backend/internal/dto/validations.go` (+10 -0) 📝 `backend/internal/service/oidc_service.go` (+9 -3) 📝 `backend/internal/service/oidc_service_test.go` (+14 -8) 📝 `frontend/messages/en.json` (+4 -1) 📝 `frontend/src/lib/services/oidc-service.ts` (+2 -1) 📝 `frontend/src/lib/types/oidc.type.ts` (+7 -1) 📝 `frontend/src/lib/utils/zod-util.ts` (+2 -4) 📝 `frontend/src/routes/settings/admin/api-keys/api-key-form.svelte` (+2 -2) 📝 `frontend/src/routes/settings/admin/oidc-clients/+page.svelte` (+1 -1) 📝 `frontend/src/routes/settings/admin/oidc-clients/[id]/+page.svelte` (+1 -1) 📝 `frontend/src/routes/settings/admin/oidc-clients/oidc-client-form.svelte` (+31 -5) 📝 `tests/specs/oidc-client-settings.spec.ts` (+50 -26) </details> ### 📄 Description Allows users to set a custom client ID for new clients. Fixes #508. Thanks to @James18232 for the foundation of this PR in #830. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2025-10-09 16:53:13 +03:00

OVERLORD closed this issue

2025-10-09 16:53:13 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pocket-id-pocket-id-2#586